Made some constructors explicit.

NuiCpp · Sep 15, 2023 · 81e5a51 · 81e5a51
1 parent a218235
commit 81e5a51
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 20 deletions.
diff --git a/nui/include/nui/frontend/components/dialog.hpp b/nui/include/nui/frontend/components/dialog.hpp
@@ -32,11 +32,11 @@ namespace Nui::Components
 
         struct ConstructionArgs
         {
-            Observed<std::optional<std::string>> className = std::nullopt;
-            Observed<std::string> title = "";
-            Observed<std::string> body = "";
-            Observed<std::string> buttonClassName = "";
-            Observed<ButtonConfiguration> buttonConfiguration = ButtonConfiguration::Ok;
+            Observed<std::optional<std::string>> className{std::nullopt};
+            Observed<std::string> title{""};
+            Observed<std::string> body{""};
+            Observed<std::string> buttonClassName{""};
+            Observed<ButtonConfiguration> buttonConfiguration{ButtonConfiguration::Ok};
             std::function<void(Button)> onButtonClicked = [](Button) {};
         };
 

diff --git a/nui/include/nui/frontend/dom/basic_element.hpp b/nui/include/nui/frontend/dom/basic_element.hpp
@@ -13,7 +13,7 @@ namespace Nui::Dom
     class BasicElement : public std::enable_shared_from_this<BasicElement>
     {
       public:
-        BasicElement(Nui::val val)
+        explicit BasicElement(Nui::val val)
             : element_{std::move(val)}
         {}
         virtual ~BasicElement() = default;

diff --git a/nui/include/nui/frontend/dom/childless_element.hpp b/nui/include/nui/frontend/dom/childless_element.hpp
@@ -17,10 +17,10 @@ namespace Nui::Dom
     class ChildlessElement : public BasicElement
     {
       public:
-        ChildlessElement(HtmlElement const& elem)
+        explicit ChildlessElement(HtmlElement const& elem)
             : BasicElement{ChildlessElement::createElement(elem)}
         {}
-        ChildlessElement(Nui::val val)
+        explicit ChildlessElement(Nui::val val)
             : BasicElement{std::move(val)}
         {}
 

diff --git a/nui/include/nui/frontend/dom/element.hpp b/nui/include/nui/frontend/dom/element.hpp
@@ -46,13 +46,13 @@ namespace Nui::Dom
         using const_iterator = collection_type::const_iterator;
         using value_type = collection_type::value_type;
 
-        Element(HtmlElement const& elem)
+        explicit Element(HtmlElement const& elem)
             : ChildlessElement{elem}
             , children_{}
             , unsetup_{}
         {}
 
-        Element(Nui::val val)
+        explicit Element(Nui::val val)
             : ChildlessElement{std::move(val)}
             , children_{}
             , unsetup_{}

diff --git a/nui/include/nui/frontend/dom/reference.hpp b/nui/include/nui/frontend/dom/reference.hpp
@@ -13,7 +13,7 @@ namespace Nui::Dom
     struct ReferencePasser
     {
       public:
-        ReferencePasser(T&& func)
+        explicit ReferencePasser(T&& func)
             : func_{std::move(func)}
         {}
         void operator()(std::weak_ptr<BasicElement>&& weakElement) const

diff --git a/nui/include/nui/frontend/event_system/observed_value.hpp b/nui/include/nui/frontend/event_system/observed_value.hpp
@@ -171,7 +171,7 @@ namespace Nui
         ~ModifiableObserved() = default;
 
         template <typename T = ContainedT>
-        ModifiableObserved(T&& t)
+        explicit ModifiableObserved(T&& t)
             : contained_{std::forward<T>(t)}
         {}
 
@@ -532,12 +532,12 @@ namespace Nui
             , afterEffectId_{registerAfterEffect()}
         {}
         template <typename T = ContainerT>
-        ObservedContainer(T&& t)
+        explicit ObservedContainer(T&& t)
             : ModifiableObserved<ContainerT>{std::forward<T>(t)}
             , rangeContext_{static_cast<long>(contained_.size())}
             , afterEffectId_{registerAfterEffect()}
         {}
-        ObservedContainer(RangeEventContext&& rangeContext)
+        explicit ObservedContainer(RangeEventContext&& rangeContext)
             : ModifiableObserved<ContainerT>{}
             , rangeContext_{std::move(rangeContext)}
             , afterEffectId_{registerAfterEffect()}
@@ -1039,7 +1039,7 @@ namespace Nui
             : ObservedContainer<std::set<Parameters...>>{RangeEventContext{0, true}}
         {}
         template <typename T = std::set<Parameters...>>
-        Observed(T&& t)
+        explicit Observed(T&& t)
             : ObservedContainer<std::set<Parameters...>>{
                   std::forward<T>(t),
                   RangeEventContext{static_cast<long>(t.size()), true}}
@@ -1123,7 +1123,7 @@ namespace Nui
         struct CopiableObservedWrap // minimal wrapper to make Observed<T> copiable
         {
           public:
-            constexpr CopiableObservedWrap(Observed<T> const& observed)
+            explicit constexpr CopiableObservedWrap(Observed<T> const& observed)
                 : observed_{&observed}
             {}
 

diff --git a/nui/include/nui/frontend/event_system/observed_value_combinator.hpp b/nui/include/nui/frontend/event_system/observed_value_combinator.hpp
@@ -12,10 +12,10 @@ namespace Nui
     class ObservedValueCombinatorBase
     {
       public:
-        constexpr ObservedValueCombinatorBase(ObservedValues const&... observedValues)
+        explicit constexpr ObservedValueCombinatorBase(ObservedValues const&... observedValues)
             : observedValues_{observedValues...}
         {}
-        constexpr ObservedValueCombinatorBase(std::tuple<ObservedValues const&...> observedValues)
+        explicit constexpr ObservedValueCombinatorBase(std::tuple<ObservedValues const&...> observedValues)
             : observedValues_{std::move(observedValues)}
         {}
 

diff --git a/nui/include/nui/frontend/event_system/range.hpp b/nui/include/nui/frontend/event_system/range.hpp
@@ -6,7 +6,7 @@ namespace Nui
     class ObservedRange
     {
       public:
-        constexpr ObservedRange(ObservedValue& observedValues)
+        explicit constexpr ObservedRange(ObservedValue& observedValues)
             : observedValue_{observedValues}
         {}
 

diff --git a/nui/include/nui/frontend/event_system/range_event_context.hpp b/nui/include/nui/frontend/event_system/range_event_context.hpp
@@ -182,7 +182,7 @@ namespace Nui
     class RangeEventContext
     {
       public:
-        RangeEventContext(long dataSize)
+        explicit RangeEventContext(long dataSize)
             : modificationRanges_{}
             , fullRangeUpdate_{true}
             , disableOptimizations_{false}