Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][OU-IMP] new analysis (December 2024) #4694

Merged
merged 5 commits into from
Jan 22, 2025
Merged

[15.0][OU-IMP] new analysis (December 2024) #4694

merged 5 commits into from
Jan 22, 2025

Conversation

MiquelRForgeFlow
Copy link
Contributor

It's time.

@MiquelRForgeFlow MiquelRForgeFlow added this to the 15.0 milestone Dec 11, 2024
@MiquelRForgeFlow MiquelRForgeFlow changed the title [15.0][UPD] new analysis [15.0][UPD] new analysis (2024) Dec 11, 2024
@pedrobaeza
Copy link
Member

[UPD] tag doesn't exist. I don't know why a lot of people uses it.

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

It's the same like saying "I do something... What? You don't know".

@MiquelRForgeFlow
Copy link
Contributor Author

The [OU] tag also doesn't exist 😏

@pedrobaeza
Copy link
Member

It's not [OU], it's [OU-ADD], [OU-IMP], etc, as an extension of the current tag system for indicating that is restricted to the OpenUpgrade scope, as if we put [ADD], we are not adding a whole module, just the migration scripts. It should be indeed reflected in the documentation though. Can you do the corresponding PR?

For this one, I think it should be [OU-IMP].

@MiquelRForgeFlow MiquelRForgeFlow changed the title [15.0][UPD] new analysis (2024) [15.0][OU-IMP] new analysis (2024) Dec 11, 2024
MiquelRForgeFlow
MiquelRForgeFlow commented Dec 17, 2024
View reviewed changes
openupgrade_scripts/scripts/hr/15.0.1.1/noupdate_changes.xml
@@ -4,6 +4,9 @@
<field name="address_id" ref="base.main_partner"/>
<field name="department_id" ref="dep_administration"/>
</record>-->
<record id="offboarding_setup_compute_out_delais" model="hr.plan.activity.type">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I should comment this record

@legalsylvain legalsylvain mentioned this pull request Jan 7, 2025
Open
@MiquelRForgeFlow MiquelRForgeFlow changed the title [15.0][OU-IMP] new analysis (2024) [15.0][OU-IMP] new analysis (December 2024) Jan 22, 2025
@MiquelRForgeFlow
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-4694-by-MiquelRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4141ec8 into OCA:15.0 Jan 22, 2025
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4141ec8. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-upd-new_analysis branch January 22, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiquelRForgeFlow @pedrobaeza @OCA-git-bot