Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] ADD account_receipt_journal: Define and use journals dedicated to receipts #1260

Merged
merged 72 commits into from
Feb 2, 2023

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Oct 10, 2022

No description provided.

@eLBati
Copy link
Member Author

eLBati commented Oct 10, 2022

@eLBati eLBati force-pushed the 14.0-account_receipt_journal branch from 03f6c12 to 6ebc1af Compare October 10, 2022 14:19
@primes2h
Copy link
Contributor

https://github.com/OCA/account-invoicing/actions/runs/3219774473/jobs/5265595874 @primes2h does this error say anything to you?

Mmhh... It's due to this, committed 7 days ago:

odoo/odoo@7a415fe

I'll try to fix account_receipt_print as soon as i can. Tomorrow, I hope.

@primes2h
Copy link
Contributor

https://github.com/OCA/account-invoicing/actions/runs/3219774473/jobs/5265595874 @primes2h does this error say anything to you?

Mmhh... It's due to this, committed 7 days ago:

odoo/odoo@7a415fe

I'll try to fix account_receipt_print as soon as i can. Tomorrow, I hope.

@eLBati
It has been fixed in #1262

Thanks @Saran440 @kittiu !

@aleuffre
Copy link

aleuffre commented Jan 13, 2023

WARNING test odoo.addons.base.models.ir_model: Two fields (receipt_ids, receipts) of sale.order() have the same label: Receipts. 

Aside from the warning, tested it on a local installation (in the context of a migration from 12.0 and the previous l10n_it module) and it seems to be working great!

I used these queries in a pre-migrate.py file on v14 to migrate my existing receipts:

openupgrade.logged_query(
    env.cr,
    """UPDATE account_move am
    SET type = 'out_receipt'
    where am.id in (SELECT am2.id
    FROM account_move am2
    JOIN account_invoice ai on am2.old_invoice_id = ai.id
    WHERE ai.type = 'out_invoice'
    AND ai.corrispettivo = true)""",
)
openupgrade.logged_query(
    env.cr,
    """UPDATE account_move am
    SET type = 'in_receipt'
    where am.id in (SELECT am2.id
    FROM account_move am2
    JOIN account_invoice ai on am2.old_invoice_id = ai.id
    WHERE ai.type = 'in_invoice'
    AND ai.corrispettivo = true)""",
)

maybe they can be used in the migrations of this module or directly in openupgrade?

@eLBati
Copy link
Member Author

eLBati commented Feb 1, 2023

maybe they can be used in the migrations of this module or directly in openupgrade?

This is included in #1267

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eLBati ! 👍

Great thing!

@rafaelbn rafaelbn added this to the 15.0 milestone Feb 2, 2023
@rafaelbn rafaelbn closed this Feb 2, 2023
@rafaelbn rafaelbn reopened this Feb 2, 2023
@rafaelbn
Copy link
Member

rafaelbn commented Feb 2, 2023

/ocabot rebase

eLBati and others added 5 commits February 2, 2023 16:55
[imp] not working view

[imp] not working defaults

[IMP] working draft

[IMP] semplified view

[ADD] translations

[FIX] partner type

[fix] defaults

[IMP] configuration wizard

[imp] translation

[imp] translation

[IMP] description

[FIX] copyright

[DEL] every module, as they are developed for 6.1.
As soon as we port a module to 7.0, before 7.0 was released,
we'll put it here
oca-travis and others added 15 commits February 2, 2023 16:55
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_corrispettivi
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_corrispettivi/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1260-by-rafaelbn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2023
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1260-by-rafaelbn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2023
Signed-off-by rafaelbn
@rafaelbn
Copy link
Member

rafaelbn commented Feb 2, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1260-by-rafaelbn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 379e265 into OCA:14.0 Feb 2, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba7f3fd. Thanks a lot for contributing to OCA. ❤️

odooNextev pushed a commit to odooNextev/account-invoicing that referenced this pull request Sep 29, 2023
Signed-off-by AaronHForgeFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.