[14.0][IMP] account_invoice_refund_link: Make more reliable the linking #1524
Conversation
Hooking on a high level method like `_reverse_move_vals` (although still being private), makes that other modules hooking into it may alter the number of returned lines (like for example, account_invoice_refund_line_selection). We choose the low-level `copy_data` method that is used in such method for linking the refund lines with their origin ones, avoiding the problem.
|
Unrelated CI error. |
|
On my way to merge this fine PR! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1524-by-rafaelbn-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
CI was red due to another module, failing also in main branch. I have disabled the conflicting tests in 9148906, and I'll ping the maintainer to check in an issue. Now, we can merge: /ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 09ab26a. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
14.0-imp-account_invoice_refund_link-solid_linking
branch
Forward-port of #1523
Hooking on a high level method like
_reverse_move_vals(although still being private), makes that other modules hooking into it may alter the number of returned lines (like for example, account_invoice_refund_line_selection).We choose the low-level
copy_datamethod that is used in such method for linking the refund lines with their origin ones, avoiding the problem.@Tecnativa