[13.0][FIX] account_invoice_show_currency_rate: use only debit from currency lines to get rate #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y lines to get rate
|
Hi @victoralmau, |
GuillemCForgeFlow
approved these changes
Nov 8, 2024
|
Could you check this one? :) |
MiquelRForgeFlow
approved these changes
Nov 8, 2024
victoralmau
approved these changes
Nov 8, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at b7ad0cc. Thanks a lot for contributing to OCA. ❤️ |
MiquelRForgeFlow
deleted the
13.0-fix-account_invoice_show_currency_rate-currency_rate_amount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With anglo-saxon accounting, the booking of the COGS and stock interim account is done always in company currency. With the current logic, we are considering the extra debit of the COGS in the invoices which has no amount currency and the resulting rate is incorrect.