Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] subscription_oca #999

Merged
merged 9 commits into from
Oct 12, 2023
Merged

[14.0][MIG] subscription_oca #999

merged 9 commits into from
Oct 12, 2023

Conversation

ilyasProgrammer
Copy link
Member

@ilyasProgrammer ilyasProgrammer commented Oct 9, 2023 •
edited
Loading

backport from 15.0

@ilyasProgrammer ilyasProgrammer changed the title [14.0][MIG] subscription_oca [14.0][MIG] subscription_oca WIP Oct 10, 2023
@ilyasProgrammer ilyasProgrammer changed the title [14.0][MIG] subscription_oca WIP [14.0][MIG] subscription_oca Oct 11, 2023
@francesco-ooops
Copy link
Contributor

@carlos-domatix @simahawk good for you? :)

geomer198
geomer198 approved these changes Oct 11, 2023
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok!

simahawk
simahawk approved these changes Oct 12, 2023
View reviewed changes
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly skimmed through it: LG

subscription_oca/__manifest__.py
@@ -10,6 +10,7 @@
"license": "AGPL-3",
"author": "Domatix, Odoo Community Association (OCA)",
"depends": ["sale_management", "account"],
"maintainers": ["ilyasProgrammer"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing maintainer can be a separated commit that you can backport/fwd port easily ;)

@francesco-ooops
Copy link
Contributor

@simahawk go go go?

@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-999-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 410cf8d into OCA:14.0 Oct 12, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d810d59. Thanks a lot for contributing to OCA. ❤️

@damdam-s
Copy link
Member

@ilyasProgrammer @simahawk what the difference between this module and the original contract one of this repo? I think it makes a duplicate because this module seems to do (functionally speaking) than contract + product_contract together.

I must have missed something important there 😞

@francesco-ooops
Copy link
Contributor

@damdam-s the features are similar, but without the complexity of the contract module, eg #971 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geomer198 geomer198 geomer198 approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ilyasProgrammer @francesco-ooops @simahawk @OCA-git-bot @damdam-s @geomer198 @carlos-domatix