[14.0][ADD] cooperator_website_recaptcha

[huguesdk]

move cooperator_website_recaptcha module from coopiteasy/vertical-cooperative to the oca.

this branch contains an extra refactoring commit (from the 14.0-ref-cooperator_website_recaptcha_to_portal_recaptcha branch) that should be reviewed. this refactoring depends on #42 and OCA/website#928.

[carmenbianca]

LGTM

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[robinkeunen]

@carmenbianca or @huguesdk can you have a look at the tests ?

[robinkeunen]

and in #43 (comment) as well

[huguesdk]

@robinkeunen these tests fail because they depend on OCA/website#928 which is not merged (but ci passes). i was about to ping a maintainer to merge it, but i saw that the ci on the 12.0 version of that branch (OCA/website#928) fails because of OCA/maintainer-quality-tools#712. i’ve just created OCA/maintainer-quality-tools#715 to fix it. let’s see if this will make things move forward.

[victor-champonnois]

LGTM (functional and code)
I see the refacto will prevent from being able to configure the recaptcha by company. Is it an issue with the new multi-company functionalities ?

[victor-champonnois]

Todo :

• write test
• Need to wait for [14.0][ADD] portal_recaptcha website#928 to be merged, then we can remove the test-requirements that blocks the CI

[huguesdk]

the only thing that was moved out of the company was a boolean controlling whether recaptcha is enabled or not. however, previously, the recaptcha keys were stored on the website, as we can see here. this was changed to remove the dependency on website, but this effectively made the settings global. do you know why the dependency on website had to be removed?

i think you’re right regarding multi-company. the 3 config settings should probably be stored on the company (or on the website). recaptcha keys work per domain. i don’t know yet how websites work in multi-company mode, but if different companies use different domains, they will need different recaptcha keys. maybe introduce a new module depending on portal_recaptcha and website that stores the settings on the website instead of globally?

this can be handled separately though, as it is an improvement to the current state.

[victor-champonnois]

@huguesdk OK for handling separately

[victor-champonnois]

Turns out there is a standard Odoo recaptcha module in 14, should we use it rather than portal_recaptcha ?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

i’ve refactored the module to use website_recaptcha_v2 (OCA/website#1030). tests will be failing until it is merged.

[dreispt]

Can commits be squashed please.

[huguesdk]

@dreispt since this is a move from our non-oca repository to here, i think keeping the history is important (same as for a migration pr). could you please help with getting OCA/website#1030 merged (on which this pr depends)?