[FIX] fieldservice: edge-case NoneType + datetime.timedelta #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PicchiSeba
force-pushed
the
14.0-fix-duplicate-date-err
branch
5 times, most recently
from
820190c
to
7e77896
Compare
PicchiSeba
force-pushed
the
14.0-fix-duplicate-date-err
branch
from
7e77896
to
cd5b712
Compare
max3903
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a problem were sometimes, in a few rare scenarios, the line
date_to_with_delta = start_date + timedelta(hours=hours)in the function_calc_scheduled_dates(self, vals)fails because start_date's value is None.In order to solve this issue I added a simple check and a log call to see where the problem lies.
But I just can't explain why that variable ended up with such a value in the first place. That would mean both
vals["scheduled_date_start"]andstart_date_valhad a falsy value and still it shouldn't be possible.If anyone can see what exactly the problem is I would gladly fix it in a proper way.