[15.0] fieldservice_recurring: Forward ports from 14 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recurring dates to avoid hour jumps during daylight saving time changes
It should not be allowed to select orders to be added to recurring
Use current company as default instead of user company.
Use location_id timezone prioritarily if set when generating fsm orders for a location
support multicompany
Stages are now:
draft: not started yet
progress: orders are and will continue to be generated
suspend: it can continue to generate orders but it has been put on pause
for some reason
close: no new orders will / can be generated
```dot
digraph {
draft -> progress -> suspend -> close
suspend -> progress
}
```
Why this change ?
- it was impossible to go back to progress after cancel
- pending / renew is too opinated to be in a base module,
- renew duration was hardcoded
(btw renew can be implemented by a renew_date instead of a stage
in a dedicated module)
brian10048
force-pushed
the
15.0-recurring-fwd-14
branch
from
800d419 to
f924891
Compare
brian10048
changed the title
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 12, 2023
|
@brian10048 The merge process could not be finalized, because command |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 75a52c4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends #1133
Forward port bug fixes and improvements from v14 to v15