Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] fieldservice_recurring: Forward ports from 14 #1137

Merged
merged 14 commits into from
Dec 12, 2023

Conversation

brian10048
Copy link
Contributor

Depends #1135

Forward port of bug fixes and feature improvements to v16 from v14

paradoxxxzero and others added 12 commits November 13, 2023 12:58
…recurring dates to avoid hour jumps during daylight saving time changes
It should not be allowed to select orders to be added to recurring
Use current company as default instead of user company.
Use location_id timezone prioritarily if set when generating fsm orders for a location
Stages are now:
draft: not started yet
progress: orders are and will continue to be generated
suspend: it can continue to generate orders but it has been put on pause
for some reason
close: no new orders will / can be generated

```dot

digraph {
draft -> progress -> suspend -> close
suspend -> progress
}
```

Why this change ?

- it was impossible to go back to progress after cancel
- pending / renew is too opinated to be in a base module,
- renew duration was hardcoded

(btw renew can be implemented by a renew_date instead of a stage
in a dedicated module)
@brian10048 brian10048 added this to the 16.0 milestone Nov 13, 2023
@brian10048 brian10048 requested a review from hparfr November 13, 2023 18:05
@brian10048 brian10048 self-assigned this Nov 13, 2023
@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @max3903,
some modules you are maintaining are being modified, check this out!

@brian10048 brian10048 force-pushed the 16.0-recurring-fwd-14 branch from 79aca05 to 5232f17 Compare November 13, 2023 19:25
@brian10048 brian10048 force-pushed the 16.0-recurring-fwd-14 branch from 5232f17 to 22f86df Compare November 13, 2023 19:32
@brian10048
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1137-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a8501d3 into OCA:16.0 Dec 12, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5dee969. Thanks a lot for contributing to OCA. ❤️

@brian10048 brian10048 deleted the 16.0-recurring-fwd-14 branch December 13, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants