16.0 mig l10n it reverse charge #3103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration l10n_it_reverse_charge |
|
Eseguo un rebase prima del merge |
[IMP] pep8 [FIX] typos and pep8 [IMP] l10n_it_reverse_charge refactoring [ADD] account_move_skip [IMP] skip expr [IMP] i18n [IMP] tax mapping [IMP] mandatory fields [IMP] autohide if == 0 [REM] pdb [IMP] no need to specify expr [FIX] write if no credit/debit
[ADD] l10n_it_reverse_charge: add initial draft of README [ADD] l10n_it_reverse_charge: add note about 'Integrazione IVA' [ADD] l10n_it_reverse_charge: add check if there is default credit account defined on Self Invoice Payment Journal [ADD] l10n_it_reverse_charge: set rc on invoice.line according to RC Type defined on fiscal position [FIX] l10n_it_reverse_charge: rename tax_src_id and tax_dest_id fields to be more consinstent and easier to understand their purpose [IMP] l10n_it_reverse_charge: adapt to latest OCA guidelines [FIX] l10n_it_reverse_charge: fix 'WARNING test_reverse_charge openerp.modules.loading: The model account.rc.type has no access rules' [ADD] l10n_it_reverse_charge Handle invoice supplier cancellation and reopening for method 'selfinvoice': * cancellation: both supplier invoice and selfinvoice are cancelled * reopening: data on existing selfinvoice are copied to supplier invoice [FIX] l10n_it_reverse_charge: fix WARNING account.invoice.line.create() with unknown fields: uom_id [IMP] l10n_it_reverse_charge: improve README [IMP] l10n_it_reverse_charge: add more comments for making code easier to understand [IMP] l10n_it_reverse_charge: add help to tax_ids field [FIX] l10n_it_reverse_charge: * do not copy rc_self_invoice_id * check if inv has rc_self_invoice_id before to proceed with its cancellation [FIX] l10n_it_reverse_charge: avoid product from self invoice lines to better handle related stats [ADD] 8.0-l10n_it_reverse_charge: copy self_invoice_text to self invoice name
[W7910(wrong-tabs-instead-of-spaces), ] Use wrong tabs indentation instead of four spaces FIX screenshots FIX allow to use and compute RC field in invoice line form pop up l10n_it_reverse_charge ADD "With additional supplier self invoice" to enable the creation of an additional supplier self invoice. This is tipically used for extraUE suppliers, in order to show, in supplier register, an invoice to the specified partner (tipically, my company), instead of the extraUE partner Also FIX ValueError: "local variable 'tax_code_id' referenced before assignment" while evaluating u'invoice_validate()' when tax mapping not found
FIX invoice_line_tax_ids field
…nvoice_draft due to odoo/odoo@bc8d5db (OCA#433) In this way both invoices are again set as draft.
…e with the mapping
Currently translated at 100.0% (55 of 55 strings) Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_reverse_charge Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_reverse_charge/it/
…ated from PO [FIX] l10n_it_reverse_charge: Assign RC flag only to supplier invoices [FIX] l10n_it_reverse_charge: Assign RC flag when vendor bill is created from PO Fixes the following usecase: 0. Install Purchase 1. Set Reverse Charge type for a new fiscal position _fp_rc_ 2. Assign _fp_rc_ to a new partner _partner_rc_ 3. Create a new PO with one line for _partner_rc_, confirm, receive the products 4. From the button in the created PO, create a new vendor bill Before this commit: RC flag is not set in the line of the created invoice After this commit: RC flag is set in the line of the created invoice [FIX] l10n_it_reverse_charge: Assign RC flag when vendor bill is populated with partner_id and then purchase_id
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_reverse_charge Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_reverse_charge/
Otherwise in case payment term such as 15/30 days the autoinvoice won't be payed at all.
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_reverse_charge Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_reverse_charge/
OCA/OCB@674eaa3 apparently broke odoo.addons.account.tests.common.AccountTestInvoicingCommon method init_invoice() when called with two opposed values as amounts (throws odoo.exceptions.UserError: Cannot create unbalanced journal entry) One test (test_intra_EU_zero_total) disabled. If/when init_invoice() is fixed, it will trigger a failure, or the test will be rewritten to adapt to the new behaviour, whichever comes first.
This reverts commit 0e2ade3.
Currently translated at 100.0% (58 of 58 strings) Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_reverse_charge Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_reverse_charge/it/
…inv] contains only one ID
'name' is now what 'number' used to be. We should use 'ref'
TonyMasciI
force-pushed
the
16.0-mig-l10n_it_reverse_charge
branch
from
fb152b3
to
c2e2dd8
Compare
|
secondo me la casistica integrazione IVA non serve perchè è già gestita dallo standard. Questo semplificherebbe l'implementazione. |
|
@TonyMasciI pensi tu abbia qualche possibilità di verificare la problematica da me evidenziata nei giorni a venire? Altrimenti valutiamo di proporre una PR di migrazione alternativa che integri quelle parti, partendo ovviamente dal tuo ottimo lavoro |
|
@TonyMasciI AgileBG si prende carico di proporre a breve una PR alternativa che incorpori i commit mancanti |
Guarda per me va bene semplicemente queste settimane non c'è semplicemente stato tempo di guardare bene la tua segnalazione...ma se devi creare una nuova PR, ti direi basta fare una PR verso la mia branch (dovrebbe essere possibile) aggiungedo quello che serve così da non creare entropia sul Repo base. |
|
Segnalo il commit su |
|
Ho aperto la PR #3300 che sostituisce ed integra la presente |
|
Chiudo in favore di #3300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.