Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] l10n_it_vat_statement_split_payment #3395

Closed

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Jun 19, 2023

Migration l10n_it_vat_statement_split_payment from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@tafaRU
Copy link
Member

tafaRU commented Jun 20, 2023

/ocabot migration l10n_it_vat_statement_split_payment

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 20, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 20, 2023
79 tasks
@tafaRU
Copy link
Member

tafaRU commented Jul 6, 2023

@Borruso controlla i tests per favore. Grazie.

@Borruso
Copy link
Contributor Author

Borruso commented Jul 6, 2023

@Borruso controlla i tests per favore. Grazie.

test ok

@SirAionTech
Copy link
Contributor

#3387 è stata mergiata, puoi eliminare l'ultimo commit e fare rebase

Matteo Bilotta and others added 23 commits October 3, 2023 08:16
Currently translated at 66.7% (6 of 9 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_statement_split_payment/it/
Fix conto per lo split payment da usare il liquidazione
…nes in taxes, use default company journals

Also use common setup for invoicing tests
Currently translated at 77.7% (7 of 9 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_split_payment/it/
Currently translated at 88.8% (8 of 9 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_split_payment/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_split_payment/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_split_payment/it/
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_vat_statement_split_payment branch from 6c196d4 to 88e08e9 Compare October 3, 2023 06:16
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cls.term_line_model.create(
{
"value": "balance",
"days": 16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non ci andrebbe anche

Suggested change
"days": 16,
"days": 16,
"end_month": True,

?

Comment on lines 250 to 265
def test_account_sp_company(self):
account_user_type = self.env.ref("account.data_account_type_receivable")
account_sp = self.account_model.create(
dict(
code="split_payment_acc",
name="Split payment account",
user_type_id=account_user_type.id,
reconcile=True,
)
)
self.company.sp_account_id = account_sp.id

Copy link
Contributor

@SirAionTech SirAionTech Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questo non mi sembra essere necessario per la migrazione, puoi aprire una issue per riportare la correzione anche nelle altre versioni come descritto in https://github.com/OCA/l10n-italy/wiki/Team-di-sviluppo#apertura-issue?
Per facilitare il porting alle altre versioni, sarebbe anche comodo avere la modifica in un commit dedicato.

@SirAionTech
Copy link
Contributor

Prendo in carico per risolvere i punti aperti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.