Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] l10n_it_pos_fatturapa #3482

Merged
merged 13 commits into from
Jul 14, 2023

Conversation

aleuffre
Copy link
Contributor

Superseeds #3414

Include fix legati ai commenti dalla review di @GSLabIt

Ping @robyf70

Copy link
Contributor

@GSLabIt GSLabIt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor

l10n_it_pos_fatturapa/models/res_partner.py Outdated Show resolved Hide resolved
@aleuffre aleuffre force-pushed the 14.0-mig-l10n_it_pos_fatturapa branch from 8a442f2 to 7effafb Compare July 11, 2023 08:20
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionale ok!

@OCA/local-italy-maintainers possiamo mergiare?

Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francesco-ooops
Copy link
Contributor

@OCA/local-italy-maintainers approvato anche dal maintainer, si può mergiare? (ve prego!)

@robyf70
Copy link
Contributor

robyf70 commented Jul 14, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3482-by-robyf70-bump-nobump, awaiting test results.

@tafaRU
Copy link
Member

tafaRU commented Jul 14, 2023

@OCA/local-italy-maintainers approvato anche dal maintainer, si può mergiare? (ve prego!)

non vedo dove 👀, intendevi forse dall'autore del modulo originale?

@francesco-ooops
Copy link
Contributor

@tafaRU il maintainer è @robyf70 (per questo ha potuto lanciare il comando di merge)

@tafaRU
Copy link
Member

tafaRU commented Jul 14, 2023

ok, beccato! https://github.com/PyTech-SRL/l10n-italy/blob/1892a4e92996f27e661b634ac1d1ab5bfc77f20a/l10n_it_pos_fatturapa/__manifest__.py#L14

@OCA-git-bot OCA-git-bot merged commit 4f6bdda into OCA:14.0 Jul 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9e05c8b. Thanks a lot for contributing to OCA. ❤️

@tafaRU
Copy link
Member

tafaRU commented Jul 14, 2023

@tafaRU il maintainer è @robyf70 (per questo ha potuto lanciare il comando di merge)

mi ha ingannato il fatto che non lo vedessi sul __manifest__ del modulo 14.0 😉

@francesco-ooops
Copy link
Contributor

@tafaRU puoi aggiornare #1905 e chiudere le altre PR segnalate per lo stesso modulo? :)

@tafaRU tafaRU mentioned this pull request Jul 14, 2023
76 tasks
@tafaRU
Copy link
Member

tafaRU commented Jul 14, 2023

@tafaRU puoi aggiornare #1905 e chiudere le altre PR segnalate per lo stesso modulo? :)

done!

@francesco-ooops
Copy link
Contributor

grazie mille!

@aleuffre aleuffre deleted the 14.0-mig-l10n_it_pos_fatturapa branch October 31, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.