Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FW-PORT] mrp_restrict_lot : avoid duplicate mo name in case of cancellation qty changes ... #1258

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][FW-PORT] mrp_restrict_lot : avoid duplicate mo name in case of cancellation qty changes ... #1258

wants to merge 1 commit into from

Conversation

metaminux
Copy link

Forward port of #1010

@OCA-git-bot
Copy link
Contributor

Hi @florian-dacosta,
some modules you are maintaining are being modified, check this out!

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@metaminux
Copy link
Author

metaminux commented Aug 13, 2024 •
edited
Loading

Hello @florian-dacosta,

Can you take a look on this PR ? This is just forward porting...

Regards,

florian-dacosta
florian-dacosta reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I believe it would be nice to add an index to the field lot_producing_id, since Odoo will make an systematic search on it...
What do you think ?

florian-dacosta
florian-dacosta approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it anyway since it has been this way in v14
I still think it deserves an index, but it can be added in an other PR anyway

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-dacosta florian-dacosta florian-dacosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@metaminux @OCA-git-bot @florian-dacosta @bguillot