Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] mrp_restrict_lot : fills Lot/Serial Number to produce with the … #1259

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

metaminux
Copy link

…restricted one from finished move

This PR is linked to OCA/stock-logistics-workflow#1560 and OCA/sale-workflow#3057

If lot/serial number restriction changes on the main product stock move of a manufacturing order, the Lot/Serial Number of the manufacturing order is updated accordingly.

@OCA-git-bot
Copy link
Contributor

Hi @florian-dacosta,
some modules you are maintaining are being modified, check this out!

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@metaminux
Copy link
Author

Still waiting for dependencies to be merged...

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 18, 2024
@metaminux
Copy link
Author

Hi @florian-dacosta

Now that OCA/stock-logistics-workflow#1560 has been merged, can we process this one ?

@metaminux metaminux force-pushed the 16.0-mrp_restrict_lot_propagation branch from c3baf00 to c8158cd Compare October 9, 2024 12:07
@florian-dacosta
Copy link
Contributor

@metaminux I am not 100% comfortable with this one for now.
For now, the lot_producing_id is set on the MO by the pull rule, and at this stage, there is no restrict lot on the finished move.
Meaning that if for any reason, the recompute is triggered, the lot_production_id will be cleared on the MO...
Well, maybe there are no reason for a recompute to happen, but it seems quite risky to me.

Maybe just overriding the write on the finished move to propagate the lot would be better in this case ?
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants