Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mrp_tag: Migration to 17.0 #1270

Merged
merged 20 commits into from
Sep 4, 2024

Conversation

aarribas-alquemy
Copy link

No description provided.

@aarribas-alquemy aarribas-alquemy mentioned this pull request May 7, 2024
15 tasks
@aarribas-alquemy aarribas-alquemy marked this pull request as draft May 7, 2024 11:27
@aarribas-alquemy aarribas-alquemy marked this pull request as ready for review May 7, 2024 11:27
Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review on runboat.

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration mrp_tag

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 21, 2024
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check field positioning?

In previous versions, the tags were placed just before the status.

image

Could you adjust that?

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when migration commits rebase into one, tested in runboat and code review

@peluko00
Copy link

peluko00 commented Sep 4, 2024

@LoisRForgeFlow seems it's ready to merge when rebase the migration commits into one

@peluko00
Copy link

peluko00 commented Sep 4, 2024

@aarribas-alquemy can you rebase the 2 migration commits into one. Thanks!

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the migration commits are rebased into one, LGTM tested in runboat

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested in runboat, but please, squash commits.

@aarribas-alquemy
Copy link
Author

Commits rebased into one.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1270-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c47d894 into OCA:17.0 Sep 4, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cfe3d1a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.