[16.0][FIX] add addClassCleanup in testcase

[chaule97]

The test class in the product_abc_classification_sale_stock module has the same name as a test class in product_abc_classification, which is causing an error in GitHub CI in #1561, #1683

[OCA-git-bot]

Hi @lmarion-source, @lmignon, @rousseldenis,
some modules you are maintaining are being modified, check this out!

[rousseldenis]

The test class in the product_abc_classification_sale_stock module has the same name as a test class in product_abc_classification, which is causing an error in GitHub CI in #1561, #1683

@chaule97 I agreed on name change because it is duplicated from base module.

But the errors you point to are not related to that.

Please highlight the real problem you want to solve

[lmignon]

Thank you for the contribution but the name of a test class should never cause problem when running tests... IMO the diagnostic is not right. Moreover when you change the name of a class into a module named as the call, the module must also be renamed....

[rousseldenis]

@chaule97 https://github.com/OCA/product-attribute/blob/16.0/base_product_mass_addition/tests/test_product_mass_addition.py#L21

This is the real error.

Missing a teardown(). See https://github.com/OCA/odoo-test-helper/blob/master/README.rst

You do the fix ?

[rousseldenis]

Or @legalsylvain ?

[chaule97]

@chaule97 https://github.com/OCA/product-attribute/blob/16.0/base_product_mass_addition/tests/test_product_mass_addition.py#L21

This is the real error.

Missing a teardown(). See https://github.com/OCA/odoo-test-helper/blob/master/README.rst

You do the fix ?

Thanks. I will continue it

[legalsylvain]

Feel free to add the teardown in this PR.

[chaule97]

Thanks everyone, I have added teardown

[legalsylvain]

thanks @chaule97 !

[lmignon]

It's better to register the call to the restore_registry method in the list of cleanup methods to execute when all the tests into the class are executed just after the fake registry is backed up

cls.loader.backup_registry()
cls.addClassCleanup(cls.loader.restore_registry)

In this way, even if an exception occurs into your setup, the registry will be cleaned up

[rousseldenis]

@lmignon Isn't it supported by test class ?

If not, odoo-test-helper documentation should be adapted too.

[chaule97]

@lmignon I have changed it

[lmignon]

see my last comment

[lmignon]

@chaule97 This change is useless but if you change the classname you must change the filename.

[chaule97]

I have renamed

[lmignon]

IMO this change is useless and we must avoid useless changes. Is-it really a problem for you?

[chaule97]

okay, I have removed this commit. I remember Odoo 17 have issue when it have duplicate testcase class name. I think that it was fixed in version 18.0

OCA/pos#1232

[lmignon]

Thank you for this fix!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖