Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] product_configurator_sale (Custom Values on Reconfigure) #58

Merged
merged 1 commit into from
Feb 15, 2022
Merged

[14.0][FIX] product_configurator_sale (Custom Values on Reconfigure) #58

merged 1 commit into from
Feb 15, 2022

Conversation

patrickrwilson
Copy link
Contributor

Applies same fix found here: pledra/odoo-product-configurator#185

@patrickrwilson
Copy link
Contributor Author

@dreispt can you please review

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 8, 2022

Can you squash please?

@patrickrwilson patrickrwilson force-pushed the product_configurator_sale_custom_value_fix branch from e5ba742 to 85ab16b Compare February 8, 2022 16:03
@dreispt
Copy link
Sponsor Member

dreispt commented Feb 8, 2022

@patrickrwilson Note for future commit messages: don't include the Odoo version "[14.0]", only the type of change "[FIX]".
I usually try to have an explanatory message that I could send to a user to explain the benefit.
Maybe: [FIX] product_configurator_sale: keep Custom Values on Reconfigure ?

@dreispt
Copy link
Sponsor Member

dreispt commented Feb 15, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-58-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 15, 2022
@OCA-git-bot
Merge PR #58 into 14.0
acd8477 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-58-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5adcc62 into OCA:14.0 Feb 15, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6d17c71. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickrwilson @dreispt @OCA-git-bot