Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_variant_default_code: Migration to 17.0 #369

Closed

Conversation

arantxa-s73
Copy link

Module migrated to version 17.0

alfredo and others added 30 commits October 16, 2024 11:01
…der_default_code

Separate the default code assignment in 2 steps, one obtains the
code and the other set this value on product.
Now is easier to extend this method.
* IMP dependency, field name, complete view

* FIX move sale.settings to base settings

* IMP reference mask use untranslate attribute names

* FIX some tests with @chienandalu remarks
* [IMP] Improve French (fr) translation
* [FIX] Fixed bad display of config. settings
* [FIX] Display product attribute value code when open the product attribute form view from product form view
Currently translated at 63.6% (14 of 22 strings)

Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/hr/
Currently translated at 100.0% (22 of 22 strings)

Translation: product-variant-12.0/product-variant-12.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_default_code/pt/
missing the possibility to edit of attribute code in form view (and also tree view)
It was present in tree view, but not in form view, and now the tree
is not editable.
When a variant is created, the mask is evaluated expecting the main
language term, so we should avoid taking the translated value when we
are in another language.
OCA-git-bot and others added 17 commits October 16, 2024 11:01
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/
Currently translated at 74.0% (20 of 27 strings)

Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Currently translated at 74.0% (20 of 27 strings)

Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Currently translated at 77.7% (21 of 27 strings)

Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Currently translated at 100.0% (27 of 27 strings)

Translation: product-variant-14.0/product-variant-14.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_default_code/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-variant-16.0/product-variant-16.0-product_variant_default_code
Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_default_code/
When a product is being created or edited and attributes have not yet
been added, a message is printed out in the band in case the reference
prefix has not been filled in. If there is no error, this strip should
remain hidden.

TT42976
@rousseldenis
Copy link

/ocabot migration product_variant_default_code

@OCA-git-bot
Copy link
Contributor

The migration issue (#317) has not been updated to reference the current pull request because a previous pull request (#341) is not closed.
Perhaps you should check that there is no duplicate work.
CC @astirpe

@rousseldenis
Copy link

@arantxa-s73 Could you follow exactly the procedure described here:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch

As some changes (like version number) should appear in migration commit. Thanks!

@rousseldenis
Copy link

Moreover, could you review #341 instead ?

@arantxa-s73 arantxa-s73 force-pushed the 17.0-mig-product_variant_default_code branch from 9b62acd to 49e27f9 Compare October 16, 2024 10:37
@arantxa-s73
Copy link
Author

I put the modifications in the migration pr

@arantxa-s73
Copy link
Author

No change is necessary, to see the field it is necessary to be a member of a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.