[15.0][ADD] product_variant_template_reassign: New module #373
+1,204
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
force-pushed
the
15.0-add-product_variant_template_reassign
branch
3 times, most recently
from
b333364
to
5ceb0cb
Compare
pedrobaeza
reviewed
Nov 5, 2024
product_variant_template_reassign/wizards/reassign_variant_views.xml
Outdated
Show resolved
Hide resolved
| if not new_variant: | ||
| raise UserError( | ||
| _( | ||
| "The attributes selected didn't generate a variant in the target template" |
There was a problem hiding this comment.
Suggested change
| "The attributes selected didn't generate a variant in the target template" | |
| "The selected attributes didn't generate a variant in the target template" |
| "product.template", | ||
| self.origin_product_template_id.ids, | ||
| self.target_product_template_id.id, | ||
| method="sql", |
There was a problem hiding this comment.
With method="sql", the possible default_code in the unique variant is lost, as well as other data. One possibility is to specify the merge options.
There was a problem hiding this comment.
Ok, done. Although with products with operations like done stock moves normally isn't possible
There was a problem hiding this comment.
Well, I was not talking about changing the merge method, but adding the extra parameters to indicate the field merge options.
| self.target_product_template_id.id, | ||
| method="sql", | ||
| ) | ||
| return { |
There was a problem hiding this comment.
Please drop a comment in the thread saying that it has been merged for tracking purposes.
chienandalu
force-pushed
the
15.0-add-product_variant_template_reassign
branch
from
5ceb0cb
to
b1d5b3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT51495
ready for review @carlosdauden @pedrobaeza