Add branch 18.0 (no default branch change) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Oct 7, 2024
etobella
requested changes
Oct 7, 2024
etobella
approved these changes
Oct 7, 2024
|
@sbidoul any blocker for the merge? |
|
I was wondering if we could test on a couple more repos, to save me a mass update in case something is missing in the template, but otherwise, good for me. |
|
@sbidoul we have some WIP on v18 already. I'll open another PR w/ a shortlist of repos (eg: queue, connector, etc) |
|
We are ready with |
|
My subset here #43 |
simahawk
force-pushed
the
add-v18-no-default
branch
from
a8fd695 to
54f0d32
Compare
|
IMO this is working pretty well. I don't see any other reason to wait. Do you? |
|
@sbidoul approved :) |
|
Looks like we have an issue #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible replacement for #36