[16.0][MIG] rma: Migration to 16.0 #361

pedrobaeza · 2023-08-24T12:09:36Z

Standard procedure.
Transfer view groups to nodes.
Adjusted upstream changed field names.
Converted onchanges to computed writable fields.
Replace Form by direct dictionary vals in record creation, as they don't handle now properly multiple existing fields in the view, and computed writable improve the compatibility on new values.
Replace domain returned on onchange by static domain in field.
Change maintainer.

pedrobaeza · 2023-08-24T12:11:54Z

The pre-commit error is supposed to be fixed in pylint-odoo. Probably a copier update template is needed. I also want to change refund generation without Form and remove the domain returned by the onchange.

[UPD] Update rma.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

…flow + Translated using Weblate (Spanish) [FIX] rma: views permissions Regular users don't have permissions to rma models, so we should avoid loading views that lead to permission errors. TT24986 rma 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ [FIX] rma: portal views access errors - Portal mail thread needs token config. - Unpublished products will raise AccessError on RMAs portal views for portal users due to record rules. - Ensure active_id when getting actions in rma, since we could come from a context that pollutes the expected active rma id. [IMP] rma: teams flow - If no RMA Team is set, we'll assign a default one to the new RMA. - A sequence is now used to search for the top team and assign it. - No default user is assigned when it's not in the context (i.e. portal rmas). [UPD] Update rma.pot rma 12.0.1.2.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ Translated using Weblate (Spanish) Currently translated at 96.2% (253 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

- Fix thrown error when trying to download a picking from the portal. - Add the hook method to prepare RMA values from the return pick wizard. - Add the access rule for portal users. - Show the portal 'Request RMAs' button on the sales page only to users related to the sales order. [UPD] Update rma.pot rma 12.0.1.3.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Currently translated at 100.0% (263 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

- Avoid permission blockings on users who doesn't have RMA permissions. - Add activities view on RMA list. [UPD] Update rma.pot rma 12.0.1.3.1

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

- Now it's possible to open several RMAs in a sale order from the portal - A new comment button has been added to allow the portal user to enter relevant information like serial numbers o issue description. - If the requested operation isn't set no RMA will be opened - The RMA product qty is now a numeric control with limits according to the qty available to return [FIX] rma,rma_sale: fix linter errors [UPD] Update rma.pot rma 12.0.1.4.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Not indicating account.invoice, it takes the default that is the vendor bill view. We force the suitable one.

…ype use existing lot by default. [IMP] rma: set rma to received on invoice delete. Remove 'waiting_refund' rma state. RMAs go from received to refunded. When the linked refund is deleted the rma is set to received. [UPD] Update rma.pot rma 12.0.1.4.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ [IMP] rma: incoming picking type use existing lot by default. rma 12.0.1.4.3

…ngs: [FIX+IMP] rma: usability * IMP - Now the description will be an html son we can show rich styles in the customers report. * FIX - On locked sale orders it was need to unlock them to be able to open an RMA. * IMP - Make the description label visible in the backend form so the user can easily spot it. * IMP - Added date and deadline filters. * IMP - Added pending RMAs filter. * IMP - Added late RMAs filter. * IMP - Added danger decoration in tree view rma 12.0.1.5.0 [UPD] Update rma.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ Translated using Weblate (Spanish) Currently translated at 100.0% (268 of 268 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/ [FIX] rma: return permissions When a user with no stock manager permissions was doing the return, an access error would raise. rma 12.0.1.5.1 [FIX] rma: multicompany returns The move was created with the default company [UPD] Update rma.pot rma 12.0.1.5.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/ [FIX] rma: non rma users confirm The sudo had to be before calling the records rma 12.0.1.5.3 [FIX] rma: pass company as record to procurement This upstream commit expects `company_id` as a record instead of as an integer id: odoo/odoo@836ff55 rma 12.0.1.5.4 [FIX] rma: internal users portal Internal users with no RMA permissions got an access error when entering the portal [UPD] Update rma.pot rma 12.0.1.6.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Currently translated at 62.2% (168 of 270 strings) Translation: rma-13.0/rma-13.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/

Currently translated at 1.8% (5 of 270 strings) Translation: rma-13.0/rma-13.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/zh_CN/

When a sale line has a phantom product (mrp kits) the RMA would not be possible as the wizard couldn't pair the components moves with the product in the line. With this approach, we can at least return the spare components of the original kit line. We also need some hooks to intervine in the main methods, like in invoicing.

TT28344

Allow to set the desired shipping address where the goods must be returned after the RMA is processed.

TT29594

If we place an RMA from the stock picking return wizard, we want to avoid setting the new moves to refund as that will affect the related sale lines delivered quantities count. TT42021

Currently translated at 100.0% (348 of 348 strings) Translation: rma-15.0/rma-15.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/it/

Currently translated at 90.5% (317 of 350 strings) Translation: rma-15.0/rma-15.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/es/

pedrobaeza · 2023-08-25T08:16:57Z

/ocabot migration rma

pedrobaeza · 2023-08-25T08:18:54Z

Everything ready to be reviewed.

chienandalu

I stumbled upon an issue when testing with no locations group:

rma/models/stock_picking.py

rma/wizard/rma_delivery_views.xml

chienandalu

👍

victoralmau

Don't forget to remove the migrations folder.

* Standard procedure. * Transfer view groups to nodes. * Adjusted upstream changed field names. * Converted onchanges to computed writable fields. * Replace `Form` by direct dictionary vals in record creation, as they don't handle now properly multiple existing fields in the view, and computed writable improve the compatibility on new values. * Replace domain returned on onchange by static domain in field. * Change maintainer. TT44213

pedrobaeza · 2023-08-28T12:08:14Z

/ocabot merge nobump

OCA-git-bot · 2023-08-28T12:08:30Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-361-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-08-28T12:15:23Z

Congratulations, your PR was merged at ef427e7. Thanks a lot for contributing to OCA. ❤️

This was referenced Aug 24, 2023

[16.0] [MIG] rma #336

Closed

[16.0][MIG] rma #360

Closed

Ernesto Tejeda and others added 27 commits August 25, 2023 09:15

[ADD] rma: new module

0122a02

[UPD] Update rma.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Added translation using Weblate (Portuguese (Brazil))

540da00

Translated using Weblate (Spanish)

edf0cd3

Currently translated at 100.0% (263 of 263 strings) Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

[FIX] rma: permissions for general users

cd4d0aa

- Avoid permission blockings on users who doesn't have RMA permissions. - Add activities view on RMA list. [UPD] Update rma.pot rma 12.0.1.3.1

[IMP] rma: Return created sequence on create_rma_index

cd84830

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: rma-12.0/rma-12.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

[FIX] rma: Perform refund with proper view

cedce07

Not indicating account.invoice, it takes the default that is the vendor bill view. We force the suitable one.

[IMP] rma: black, isort, prettier

15ee352

[MIG] rma: Migration to 13.0

099c9a3

[IMP] rma: Add customer as suggested recipient

9d84b44

Added translation using Weblate (Romanian)

fc46537

Currently translated at 62.2% (168 of 270 strings) Translation: rma-13.0/rma-13.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/

Added translation using Weblate (Dutch)

c5eaae3

Added translation using Weblate (Chinese (Simplified))

ef4ac28

Translated using Weblate (Chinese (Simplified))

02a2694

Currently translated at 1.8% (5 of 270 strings) Translation: rma-13.0/rma-13.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/zh_CN/

[IMP] rma: auto send confirmation email

8e6a869

[IMP] rma: automatic notification subtypes

cda887d

TT28344

[IMP] rma, rma_sale: shipping address

704649c

Allow to set the desired shipping address where the goods must be returned after the RMA is processed.

[FIX] rma: Set default source location for RMA created from scratch

f6e896d

[FIX] rma: tagged test

6ff2973

[IMP] rma: tags

adbe669

TT29594

[IMP] rma: black, isort, prettier

75e7517

[MIG] rma: Migration to 14.0

379a6c0

chienandalu and others added 5 commits August 25, 2023 09:15

[FIX] rma: avoid refunding in picking return wizard

40fa0a9

If we place an RMA from the stock picking return wizard, we want to avoid setting the new moves to refund as that will affect the related sale lines delivered quantities count. TT42021

Translated using Weblate (Italian)

a3f0da6

Currently translated at 100.0% (348 of 348 strings) Translation: rma-15.0/rma-15.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/it/

Translated using Weblate (Italian)

dd12157

Currently translated at 100.0% (348 of 348 strings) Translation: rma-15.0/rma-15.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/it/

Translated using Weblate (Spanish)

160dd58

Currently translated at 90.5% (317 of 350 strings) Translation: rma-15.0/rma-15.0-rma Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/es/

[IMP] rma: pre-commit stuff

c093db1

pedrobaeza force-pushed the 16.0-mig-rma branch from 75e6045 to 4578718 Compare August 25, 2023 08:16

OCA-git-bot added this to the 16.0 milestone Aug 25, 2023

OCA-git-bot mentioned this pull request Aug 25, 2023

Migration to version 16.0 #314

Open

7 tasks

pedrobaeza requested review from victoralmau and chienandalu August 25, 2023 08:18

chienandalu reviewed Aug 25, 2023

View reviewed changes

rma/models/stock_picking.py Outdated Show resolved Hide resolved

pedrobaeza force-pushed the 16.0-mig-rma branch from 4578718 to 46c4bbb Compare August 25, 2023 10:00

chienandalu reviewed Aug 25, 2023

View reviewed changes

rma/wizard/rma_delivery_views.xml Show resolved Hide resolved

pedrobaeza force-pushed the 16.0-mig-rma branch 2 times, most recently from 46beeea to 5783afc Compare August 25, 2023 15:19

chienandalu approved these changes Aug 28, 2023

View reviewed changes

victoralmau approved these changes Aug 28, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 28, 2023

pedrobaeza force-pushed the 16.0-mig-rma branch from 5783afc to ed3f242 Compare August 28, 2023 11:35

OCA-git-bot added the bot is merging ⏳ label Aug 28, 2023

OCA-git-bot merged commit 4baa489 into OCA:16.0 Aug 28, 2023
4 of 6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 28, 2023

pedrobaeza deleted the 16.0-mig-rma branch August 28, 2023 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] rma: Migration to 16.0 #361

[16.0][MIG] rma: Migration to 16.0 #361

pedrobaeza commented Aug 24, 2023 •

edited

Loading

pedrobaeza commented Aug 24, 2023

pedrobaeza commented Aug 25, 2023

pedrobaeza commented Aug 25, 2023

chienandalu left a comment

chienandalu left a comment

victoralmau left a comment

pedrobaeza commented Aug 28, 2023

OCA-git-bot commented Aug 28, 2023

OCA-git-bot commented Aug 28, 2023

[16.0][MIG] rma: Migration to 16.0 #361

[16.0][MIG] rma: Migration to 16.0 #361

Conversation

pedrobaeza commented Aug 24, 2023 • edited Loading

pedrobaeza commented Aug 24, 2023

pedrobaeza commented Aug 25, 2023

pedrobaeza commented Aug 25, 2023

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

victoralmau left a comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 28, 2023

OCA-git-bot commented Aug 28, 2023

OCA-git-bot commented Aug 28, 2023

pedrobaeza commented Aug 24, 2023 •

edited

Loading