[FIX] website_cookiebot: disable for sure

If we don't remove the key the assets will keep trying to load, which
isn't what we'd expect.

TT50520

website_cookiebot/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Website Cookiebot",
     "summary": "Ask for cookies consent connecting with Cookiebot",
     "category": "Website",
-    "version": "17.0.1.0.0",
+    "version": "17.0.1.0.1",
     "author": "Trey (www.trey.es), Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/website",
     "license": "AGPL-3",

website_cookiebot/models/website.py

@@ -11,3 +11,4 @@ class Website(models.Model):
         string="Cookiebot Domain Group ID",
         help="Get this code from Cookiebot to enable it on the website.",
     )
+    cookiebot_enabled = fields.Boolean()

website_cookiebot/templates/assets.xml

@@ -6,7 +6,9 @@
         <!-- This should be the first script loaded;
              see https://cookiebot.com/goto/help -->
         <xpath expr="//head/script" position="before">
-            <t t-if="website.cookiebot_dgid and not editable">
+            <t
+                t-if="website.cookiebot_enabled and website.cookiebot_dgid and not editable"
+            >
                 <script
                     id="Cookiebot"
                     src="https://consent.cookiebot.com/uc.js"
@@ -21,7 +23,7 @@
         <xpath expr="//script[@id='tracking_code']" position="attributes">
             <attribute
                 name="t-att-type"
-            >website.cookiebot_dgid and 'text/plain'</attribute>
+            >website.cookiebot_enabled and website.cookiebot_dgid and 'text/plain'</attribute>
             <attribute name="data-cookieconsent">statistics</attribute>
         </xpath>
     </template>

website_cookiebot/templates/website.xml

@@ -7,7 +7,7 @@
             expr="//footer//div/span[hasclass('o_footer_copyright_name')]"
             position="after"
         >
-                <span t-if="website.cookiebot_dgid">- <a
+                <span t-if="website.cookiebot_enabled and website.cookiebot_dgid">- <a
                     href="/legal/cookies-policy"
                 >Cookies Policy</a></span>
         </xpath>
@@ -21,7 +21,7 @@
                     </section>
                 </div>
                 <section
-                    t-if="website.cookiebot_dgid and not editable"
+                    t-if="website.cookiebot_enabled and website.cookiebot_dgid and not editable"
                     class="mb-5 mt-5"
                 >
                     <div class="container">

website_cookiebot/tests/test_website_cookiebot.py

@@ -9,6 +9,8 @@ def test_conf_cookiebot_domain(self):
         domain_group_id = "9a9999a9-aa99-9a99-999a-aa999999999a"
         config = self.env["res.config.settings"].sudo().create({})
         config.write({"cookiebot_dgid": domain_group_id})
+        config.write({"cookiebot_enabled": True})
+        config._onchange_cookiebot_enabled()
         self.assertTrue(config.cookiebot_enabled)
         self.assertFalse(config.website_cookies_bar)
         self.assertEqual(config.cookiebot_dgid, domain_group_id)

website_cookiebot/wizards/res_config_settings.py

@@ -15,15 +15,10 @@ class ResConfigSettings(models.TransientModel):
     )
     cookiebot_enabled = fields.Boolean(
         string="Cookiebot",
-        compute="_compute_cookiebot_enabled",
+        related="website_id.cookiebot_enabled",
         readonly=False,
     )
 
-    @api.depends("website_id.cookiebot_dgid")
-    def _compute_cookiebot_enabled(self):
-        for record in self:
-            record.cookiebot_enabled = bool(record.cookiebot_dgid)
-
     @api.onchange("website_cookies_bar")
     def _onchange_website_cookies_bar(self):
         for record in self: