Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] website_forum_subscription: Migration to version 16.0 #1010

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

carolinafernandez-tecnativa
  • Standard migration to v16

@Tecnativa

TT45242

@pedrobaeza @chienandalu

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)

A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-website_forum_subscription branch from 706c163 to cdb6e4a Compare October 3, 2023 13:16
@carolinafernandez-tecnativa
Copy link
Author

Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)

A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338

Hi thanks! How can i use that tool?

@chienandalu
Copy link
Member

Hi thanks! How can i use that tool?

You'll have to build a version that includes that patch and then simply:

from openupgradelib.openupgrade_160 import convert_string_bootstrap_4to5

xml = """<odoo><!-- Your xml --></odoo>"""
print(convert_string_bootstrap_4to5(xml))  # You can copy your output from the console directly

@carolinafernandez-tecnativa
Copy link
Author

Hi thanks! How can i use that tool?

You'll have to build a version that includes that patch and then simply:

from openupgradelib.openupgrade_160 import convert_string_bootstrap_4to5

xml = """<odoo><!-- Your xml --></odoo>"""
print(convert_string_bootstrap_4to5(xml))  # You can copy your output from the console directly

Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)

A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338

Goord morning,
Thanks for your help! I have checked and the only change was the one you detected, you can proceed to check it now
FYI @pedrobaeza

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot migration website_forum_subscription

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 4, 2023
13 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1010-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 325011a into OCA:16.0 Oct 4, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b846f6. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-website_forum_subscription branch October 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants