-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] website_forum_subscription: Migration to version 16.0 #1010
[16.0][MIG] website_forum_subscription: Migration to version 16.0 #1010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take care of bs4 -> bs5 classes changes (https://getbootstrap.com/docs/5.0/migration/#utilities)
A good custome is to use the tooling provided here to automate those checks: OCA/openupgradelib#338
website_forum_subscription/templates/website_forum_templates.xml
Outdated
Show resolved
Hide resolved
website_forum_subscription/templates/website_forum_templates.xml
Outdated
Show resolved
Hide resolved
706c163
to
cdb6e4a
Compare
Hi thanks! How can i use that tool? |
You'll have to build a version that includes that patch and then simply: from openupgradelib.openupgrade_160 import convert_string_bootstrap_4to5
xml = """<odoo><!-- Your xml --></odoo>"""
print(convert_string_bootstrap_4to5(xml)) # You can copy your output from the console directly |
Goord morning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/ocabot migration website_forum_subscription |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working:
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 5b846f6. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa
TT45242
@pedrobaeza @chienandalu