[16.0][FIX] website_legal_page: footer xpath #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested review from
pilarvargas-tecnativa
and removed request for
pilarvargas-tecnativa
|
LGTM! |
danielduqma
force-pushed
the
16.0-fix-website_legal_page
branch
from
15e5fc6 to
b407a2d
Compare
danielduqma
changed the title
yostashiro
approved these changes
Nov 25, 2023
| @@ -8,7 +8,7 @@ | |||
| customize_show="True" | |||
| > | |||
| <xpath | |||
| expr="//footer//div/span[hasclass('o_footer_copyright_name')]" | |||
| expr="//footer//div//span[hasclass('o_footer_copyright_name')]" | |||
There was a problem hiding this comment.
A non-blocking suggestion.
Suggested change
| expr="//footer//div//span[hasclass('o_footer_copyright_name')]" | |
| expr="//footer//span[hasclass('o_footer_copyright_name')]" |
There was a problem hiding this comment.
I see that well, I tried to reduce diff to ease merge, but the important thing here is an HTML class inside element footer. Thanks!
In some cases, Odoo wraps original span inside another span for translation, so this change allows it to be found eitherwise.
danielduqma
force-pushed
the
16.0-fix-website_legal_page
branch
from
b407a2d to
249aa31
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e79c8a8. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Odoo wraps original span inside another span for translation making view fail. This change allows it to be found eitherwise.
Steps to reproduce:
Reproduced on runboat, website My Website - 1018