Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] website_conditional_visibility_user_group: New module #1047

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Jul 8, 2024

Please review @pedrobaeza @pilarvargas-tecnativa

cc @Tecnativa TT50008

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 8, 2024
@chienandalu chienandalu force-pushed the 15.0-add-website_conditional_visibility_for_internal_user branch 2 times, most recently from 2d495eb to 149d2ad Compare July 9, 2024 08:45
@chienandalu chienandalu changed the title [15.0][ADD] website_conditional_visibility_for_internal_user: New module [15.0][ADD] website_conditional_visibility_user_group: New module Jul 9, 2024
@chienandalu chienandalu force-pushed the 15.0-add-website_conditional_visibility_for_internal_user branch 3 times, most recently from bc8c137 to 7a990d0 Compare July 10, 2024 13:04
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, thanks

@chienandalu chienandalu force-pushed the 15.0-add-website_conditional_visibility_for_internal_user branch from 7a990d0 to d291b11 Compare July 12, 2024 05:22
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested in runboat

@@ -0,0 +1,2 @@
Thsi module adds extra granularity in the visibility of the website snippets allowing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thsi module adds extra granularity in the visibility of the website snippets allowing
This module adds extra granularity in the visibility of the website snippets allowing

@chienandalu chienandalu force-pushed the 15.0-add-website_conditional_visibility_for_internal_user branch from d291b11 to 42a29ee Compare July 12, 2024 07:35
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1047-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 55b02e9 into OCA:15.0 Jul 12, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3b0bc45. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-website_conditional_visibility_for_internal_user branch July 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants