[16.0][MIG] website_menu_by_user_status: Migration to 16.0 #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending the controllers and the website xml templates is not required anymore because the field is_visible on website.menu is computed.
Currently translated at 100.0% (5 of 5 strings) Translation: website-13.0/website-13.0-website_menu_by_user_status Translate-URL: https://translation.odoo-community.org/projects/website-13-0/website-13-0-website_menu_by_user_status/es/
Currently translated at 100.0% (5 of 5 strings) Translation: website-13.0/website-13.0-website_menu_by_user_status Translate-URL: https://translation.odoo-community.org/projects/website-13-0/website-13-0-website_menu_by_user_status/ca/
[FIX][website_menu_by_user_status] fix travis [FIX][website_menu_by_user_status] force sudo Revert "[FIX][website_menu_by_user_status] force sudo" This reverts commit 71d579c.
Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_menu_by_user_status Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_menu_by_user_status/es_AR/
Currently translated at 100.0% (8 of 8 strings) Translation: website-14.0/website-14.0-website_menu_by_user_status Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_menu_by_user_status/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-14.0/website-14.0-website_menu_by_user_status Translate-URL: https://translation.odoo-community.org/projects/website-14-0/website-14-0-website_menu_by_user_status/
…funcionality. There was a bug that changes how the core works and allowed access to an unpublished page from one of its menus if it is set to visible to your logged-in or non-logged-in users, taking us to an error page
danielduqma
approved these changes
Jul 30, 2024
13 tasks
|
cc @OCA/website-maintainers |
tarteo
approved these changes
Oct 11, 2024
|
LGTM! Thanks (tested locally) |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at bb56a29. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two objectives: to make a standard migration of the website_menu_by_user_status module to v16.0 and fix a bug related to the visibility of website menus:
The _compute_visible method of the core calculates the is_visible field based on certain conditions, such as that the linked page is published.
This method calls the super of this method, and if after doing so the menu entry is not visible, it is saved as not visible, but then it is made visible if it is visible to logged in or non-logged in users.
Let's see an example:
This page is not published:
We added a menu that links to the previous page. By default, the visible checks are marked for logged in and non-logged in users:
With these settings, the menu is displayed and directed to the page, giving an error as it is not published:
This PR is responsible for fixing that error.
FL-556-1335