[FIX] website_google_tag_manager: fix hidden menu behavior with tag manager #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager Adding script before the wrapwrap element affects style [1] and hide the nav bar behind of the main menu, so it is required adding it after the wrapwrap element, the same way as [2] does it. Reference: - [1] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/static/src/scss/website.scss#L200 - [2] https://github.com/odoo/odoo/blob/32a07bf4/addons/website/views/website_templates.xml#L151
|
Hi, @luisg123v, @hugho-ad and @imanie383, please, could you review this PR? T#76185 |
This was referenced Aug 6, 2024
|
Looks fine, just verify if the tags are working ritgh after move the iframe more bottom
|
Thanks, @imanie383, I think this proves everything is OK
|
luisg123v
approved these changes
Aug 7, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c66cddb. Thanks a lot for contributing to OCA. ❤️ |
|
Hi, @moylop260, could you merge the foward ports? #1053 and #1054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding script before the wrapwrap element affects style [1] and hide the nav bar behind of the main menu, so it is required adding it after the wrapwrap element, the same way as [2] does it.
Reference:
Before:
After: