Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD]website_rewrite_absolute_url: Module to add absolute url redirects #994

Closed

Conversation

odooNextev
Copy link

@odooNextev odooNextev commented Jul 21, 2023

By default Odoo doesn't allow to add absolute url redirects. I added "Is absolute url" field, if it's checked, then it will be possible to add an absolute url redirects.
In check_url_to method I replicated default behaviours, but using routing_map.bind(rewrite.url_to) if it's an absolute url.

Example: If I want to redirect my page to google.com by default Odoo add a redirect to www.mywebsite.com/google.com
With this module you can correctly redirect to google.com

@odooNextev odooNextev force-pushed the 16.0-add-website_rewrite_absolute_url branch from 2d760a4 to 7be26a8 Compare July 21, 2023 09:21
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023
@github-actions github-actions bot closed this Dec 24, 2023
@odooNextev
Copy link
Author

@pedrobaeza What is your opinion about this pr?

@pedrobaeza
Copy link
Member

I can't say about the functionality, sorry. Reopening for now.

@pedrobaeza pedrobaeza reopened this Jan 8, 2024
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 8, 2024
@odooNextev odooNextev changed the title [ADD]website_rewrite_absolute_url: Module to add absolute url redirects [16.0][ADD]website_rewrite_absolute_url: Module to add absolute url redirects Jan 9, 2024
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is unnecessary AFAICS.

Just make sure you add http:// or https:// at the beginning of the redirected URL and base odoo will work out of the box.

Something like this:
imagen

It will perform the expected absolute redirection, without needing this module.

@odooNextev
Copy link
Author

Thanks @yajo, It works properly without this module.

@odooNextev odooNextev closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants