-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result conflict and ppxlib #814
Conversation
We have to use ppxlib >= 0.30.0 and prevent conflict with result < 1.5.
We shouldn't have a dependency on We also don't use |
I will check for the result dependency. EDIT: if you prefer, I can add |
Ah, so |
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as is then, since #815 was merged already it will make things easier for us. We can clean up the ppxlib
dependency into a conflicts
once we are done with 2.5.0
We have to use ppxlib >= 0.30.0 and prevent conflict with result < 1.5.
We have to use ppxlib >= 0.30.0 and prevent conflict with result < 1.5.