Add >>IMP INCLUDE directive

[engboris]

Closes #114 and completes FR176 on SourceForge.

A new directive >> IMP INCLUDE FILE_1 ... FILE_n is introduced, allowing to include multiple C headers. Only files with name finishing by .h are allowed.

I'm not sure about that but I marked the feature with /* GnuCOBOL 3.3 extension*/.

[GitMensch]

Thanks for this first take - please copy the tests for --include and adjust those for the directive. In gnbucobol.texi and NEWS add a remark in the --include description, that the directive can be used as an alternative.

[GitMensch]

We don't need two lists, but we need to reset the list for each source file specified on the command line to the state from cobc command line. Therefore either backup the whole list and restore it (similar to cb_source_format) or just use two lists and reset the second before each new source file. I'm ok with both ways but think the two-list approach is easier to handle.

[GitMensch]

still some requested changes - but we're on the finish line with this PR

[GitMensch]

"approved with minor changes"

[GitMensch]

changes to the testcases needed, overal fine

[engboris]

@GitMensch Could you check this? It was almost finished and it was a rather minor change but I wasn't sure about the tests. Thank you!

[GitMensch]

code changes requested for @engboris - I'll adjust the used_binaries.at, so please don't force-push

[GitMensch]

Currently the memory was allocated with cobc_malloc and would need to be always freed, and that must also be done when there is no codegen (preprocess/syntaxy-check only) so must be done outside of codegen.

I think the parse_ memory functions would be more reasonable and drop the need to execute the free, also removing the need to keep the "last" element here; the only thing missing then is to initialize cb_include_file_list_directive at the right place

[engboris]

If I understand correctly, I should free those variables outside/independently of codegen but still after the running of codegen? Maybe after ylex_clear_all () in cobc.c and add a parse_clear_all () function or something like that?

[GitMensch]

The thought was to drop all the explicit cobc_free calls and move this to "parser memory" using cobc_parse_malloc instead for the allocation; then, potentially at ylex_clear_all or clear_local_codegen_vars unset the var...

Can you please check if this works?

Note: you currently allocate cb_include_file_list_directive with cobc_parse_strdup - so it is parser allocated already and will automatically be freed - you may only need to drop setting the "last" attribute (or create a separate structure) and the free calls here.

[engboris]

you may only need to drop setting the "last" attribute (or create a separate structure) and the free calls here.

Looks like it works with that with no leak from valgrind. I didn't unset any variable (tell me if it is necessary).

[GitMensch]

overall a good state, we should be able to add the missing pieces and be able to upstream that, soon

[GitMensch]

The thought was to drop all the explicit cobc_free calls and move this to "parser memory" using cobc_parse_malloc instead for the allocation; then, potentially at ylex_clear_all or clear_local_codegen_vars unset the var...

Can you please check if this works?

Note: you currently allocate cb_include_file_list_directive with cobc_parse_strdup - so it is parser allocated already and will automatically be freed - you may only need to drop setting the "last" attribute (or create a separate structure) and the free calls here.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (2c000f5) to head (1336ded).
Report is 15 commits behind head on gcos4gnucobol-3.x.

Files with missing lines	Patch %	Lines
cobc/scanner.l	74.19%	3 Missing and 5 partials ⚠️
cobc/codegen.c	50.00%	1 Missing and 2 partials ⚠️
cobc/pplex.l	57.14%	0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           gcos4gnucobol-3.x     #143      +/-   ##
=====================================================
- Coverage              77.56%   67.80%   -9.76%     
=====================================================
  Files                     33       33              
  Lines                  60230    60413     +183     
  Branches               15834    15888      +54     
=====================================================
- Hits                   46717    40966    -5751     
- Misses                 13513    13538      +25     
- Partials                   0     5909    +5909     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.