Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert, update, delete restrictions #1770

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bdebaere
Copy link
Contributor

Add insert, update, delete restrictions based on https://www.odata.org/blog/introducing-a-capabilities-vocabulary/. It is now possible to call IsNotInsertable(), IsNotUpdatable(), IsNotDeletable() on the NavigationSourceConfiguration and NavigationSourceConfiguration. It is now also possible to call IsNotInsertable(), IsNotUpdatable(), IsNotDeletable() on the PropertyConfiguration. This results in additional annotations added where necessary.

@msftclas
Copy link

msftclas commented Feb 23, 2019

CLA assistant check
All CLA requirements met.

@bdebaere
Copy link
Contributor Author

I don’t know why the build fails. I don’t have access to check the log. It builds successfully on my local branch.

@xuzhg
Copy link
Member

xuzhg commented Feb 27, 2019

it seems the TestPublicApi failed, please update that in both projects.

@bdebaere
Copy link
Contributor Author

Sorry about that. Resolved.

@xuzhg
Copy link
Member

xuzhg commented Mar 6, 2019

@bdebaere Thanks a lot for your contribution.

However, what i am thinking is that "do we need to build these functionality in Web API OData? Should be these at use side? " And it seems Capabilities changes a lot, see https://github.com/oasis-tcs/odata-vocabularies/blob/master/vocabularies/Org.OData.Capabilities.V1.md.
I'd invite @mikepizzo share his thoughts about it.

@raheph
Copy link
Contributor

raheph commented Mar 27, 2019

@bdebaere It seems it's better to add such extension methods into OData.Edm library and use OData model builder pattern to call those extension methods.

@mikepizzo
Copy link
Member

Would really like to see this functionality added at the right level, and using the latest OASIS vocabulary.

@madansr7 madansr7 self-requested a review August 21, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants