-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update bulk ops serialization #2697
Feature/update bulk ops serialization #2697
Conversation
e493e2a
to
c8650c9
Compare
8299888
to
c0ded4a
Compare
24157e0
to
3082d76
Compare
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/ODataOutputFormatterHelper.cs
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
Could you add some context and overview of the changes in the description? |
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
068fb6b
to
0427985
Compare
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerContext.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerContext.cs
Outdated
Show resolved
Hide resolved
53ad3c2
to
c078018
Compare
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerHelper.cs
Outdated
Show resolved
Hide resolved
82432b1
to
519fd8f
Compare
9229e22
to
d1353ca
Compare
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationTest.cs
Outdated
Show resolved
Hide resolved
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationTest.cs
Outdated
Show resolved
Hide resolved
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationTest.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Show resolved
Hide resolved
11b8d3b
to
380de65
Compare
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationTest.cs
Outdated
Show resolved
Hide resolved
test/E2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationTest.cs
Outdated
Show resolved
Hide resolved
...2ETest/Microsoft.Test.E2E.AspNet.OData/Build.AspNet/BulkOperation/BulkOperationController.cs
Outdated
Show resolved
Hide resolved
a6f010f
to
22bd66b
Compare
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataDeltaFeedSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataResourceSerializer.cs
Outdated
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issues
This pull request fixes #xxx.
Description
This pull request is a sub of this big PR #2656. We have broken the big PR into 3PRs - deserialization/serialization/ApiHandlers to hasten the review. This PR contains only serialization changes for bulk operations.
This PR adds changes for serializing a DeltaSet. This is a new structure for bulk operations.
We've removed changes for serializing a response in a deep insert in this pr as there are some redesigning that need to be done for proper serialization to the required level to happen.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.