-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for logical data types. #285
Comments
One thing I noticed is that executeBatch is very slow on Oracle when there are lots of missing values. I'm not sure why. Just making a note. |
Boolean types seems to be working well on postgres, redshift, sql server. Oracle 19 (test database version) is not though. I can pass logicals to and from oracle but NA values are converted to FALSE. I'm representing them as NUMBER(1) in the database. Still need to investigate Oracle. I think latest version of oracle does have boolean types but not older versions. |
As described in Adam's post. SQLite doesn't support logical types, so we will stick to the current behavior there (convert to INT and throw a warning). We suspect we will phase out SQLite in favor of DuckDB in OHDSI in the future.
From discussion #275
The text was updated successfully, but these errors were encountered: