Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logical data types. #285

Open
schuemie opened this issue Aug 15, 2024 · 2 comments
Open

Add support for logical data types. #285

schuemie opened this issue Aug 15, 2024 · 2 comments
Assignees
Milestone

Comments

@schuemie
Copy link
Member

As described in Adam's post. SQLite doesn't support logical types, so we will stick to the current behavior there (convert to INT and throw a warning). We suspect we will phase out SQLite in favor of DuckDB in OHDSI in the future.

From discussion #275

@schuemie schuemie added this to the v7.0.0 milestone Aug 15, 2024
@ablack3
Copy link
Collaborator

ablack3 commented Aug 22, 2024

One thing I noticed is that executeBatch is very slow on Oracle when there are lots of missing values. I'm not sure why. Just making a note.

@ablack3
Copy link
Collaborator

ablack3 commented Aug 22, 2024

Boolean types seems to be working well on postgres, redshift, sql server. Oracle 19 (test database version) is not though. I can pass logicals to and from oracle but NA values are converted to FALSE. I'm representing them as NUMBER(1) in the database. Still need to investigate Oracle. I think latest version of oracle does have boolean types but not older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants