Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cdm_holder to the database_id hash #48

Closed
anthonysena opened this issue Mar 8, 2023 · 1 comment · Fixed by #157
Closed

Add cdm_holder to the database_id hash #48

anthonysena opened this issue Mar 8, 2023 · 1 comment · Fixed by #157
Labels
execution
Milestone
v1.0.0

Comments

@anthonysena
Copy link
Collaborator

anthonysena commented Mar 8, 2023 •
edited
Loading

This will prevent collisions in the case that someone has the same cdm name + release date.
@anthonysena anthonysena added this to the v0.1.1 milestone Dec 4, 2023
@anthonysena anthonysena modified the milestones: v0.1.x, v0.2.0 Dec 20, 2023
anthonysena added a commit that referenced this issue Aug 19, 2024
@anthonysena
Add cdmHolder to databaseId hash - fixes #48
61f6b06
@anthonysena anthonysena mentioned this issue Aug 19, 2024
Merged
@anthonysena anthonysena linked a pull request Aug 19, 2024 that will close this issue
Expose full CDM Database Metadata via execution settings #157
Merged
anthonysena added a commit that referenced this issue Aug 19, 2024
@anthonysena
Expose full CDM Database Metadata via execution settings (#157)
eeeb913 
* Add getCdmDatabaseMetaData function and expose database metadata in
execution settings

* Add cdmHolder to databaseId hash - fixes #48
@anthonysena
Copy link
Collaborator Author

This is now implemented in the v1.0-main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
execution
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Expose full CDM Database Metadata via execution settings OHDSI/Strategus
1 participant
@anthonysena