Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ultrasound): Upgrade cornerstone3D version to resolve coloring issues #4181

Merged
merged 18 commits into from
May 29, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented May 28, 2024

Context

For #4110

Upgrading cornerstone3D version which has solved various issues with ultrasound coloring

Epic issue #4082

it will fix
#2887
#3216
#3958
#3964
#4042
#4075
#4078
#4089

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented May 28, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 44a9088
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66572e3e6f70720008e1d59f
😎 Deploy Preview https://deploy-preview-4181--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 28, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 44a9088
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66572e3ebd0a2b000819aad2
😎 Deploy Preview https://deploy-preview-4181--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented May 28, 2024

Passing run #4012 ↗︎

0 43 0 0 Flakiness 0

Details:

Merge branch 'master' of github.com:OHIF/Viewers into fix/us-upgrade-cs3d
Project: Viewers Commit: 44a9088efb
Status: Passed Duration: 05:01 💡
Started: May 29, 2024 1:42 PM Ended: May 29, 2024 1:47 PM

Review all test suite changes for PR #4181 ↗︎

@sedghi sedghi changed the title fix/us upgrade cs3d fix(ultrasound): Upgrade cornerstone3D version to resolve coloring issues May 29, 2024
@sedghi sedghi merged commit 75a71db into master May 29, 2024
9 checks passed
@sedghi sedghi mentioned this pull request May 29, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants