Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect: add test for vlan.id - v10 #2208

Closed
wants to merge 1 commit into from
Closed

detect: add test for vlan.id - v10 #2208

wants to merge 1 commit into from

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Dec 28, 2024 •
edited
Loading

Ticket: #1065

Description:

  • Add Suricata-Verify test for vlan.id keyword

test.yaml changes:

Commit message:

  • Replace test: with detect:

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065

Previous PR: #2207
Suricata PR: OISF/suricata#12324

@AkakiAlice AkakiAlice mentioned this pull request Dec 29, 2024
Closed
5 tasks
catenacyber
catenacyber approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests for the Suricata PR

@AkakiAlice AkakiAlice mentioned this pull request Jan 2, 2025
Closed
5 tasks
@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Jan 7, 2025
@AkakiAlice AkakiAlice mentioned this pull request Jan 8, 2025
Merged
@AkakiAlice AkakiAlice closed this Jan 8, 2025
@AkakiAlice
Copy link
Contributor Author

Replaced by #2222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkakiAlice @catenacyber