Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: add test for ldap operation keywords - v6 #2248

Closed

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Jan 21, 2025

Ticket: 7453

Description:

  • Add S-V test for ldap operation keywords

Changes:

  • add comment for signatures that should not match

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7453

Suricata PR: OISF/suricata#12447
Previous PR: #2243

Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests for the Suricata PR

@victorjulien
Copy link
Member

Merged in #2253, thanks!

@catenacyber
Copy link
Collaborator

Good work Alice :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

3 participants