-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
userguide/runmodes: fix typo #12108
base: master
Are you sure you want to change the base?
userguide/runmodes: fix typo #12108
Conversation
it's a very small change and nothing much |
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12108 +/- ##
===========================================
+ Coverage 62.68% 83.15% +20.47%
===========================================
Files 840 909 +69
Lines 153669 257883 +104214
===========================================
+ Hits 96323 214445 +118122
+ Misses 57346 43438 -13908
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution :)
Before we can merge it, the merge
commit should be squashed with the main one.
We also kindly ask you to use as your GitHub e-mail for the PR author the same e-mail that you used for signing up the Contribution Agreement, please :)
The CI failure looks unrelated to your work.
69500cb
to
b327285
Compare
squashed the commits to one. |
Thanks! I missed two points in my previous comment, sorry (low on coffee today, it seems), both related to the commit message:
|
NOTE: This PR may contain new authors. |
b327285
to
c256081
Compare
changed the commit message. |
d45b593
to
d9fb729
Compare
Documentation: OISF#7383
d9fb729
to
49fda0c
Compare
is everything ok to be merged or do i need to do something else? |
It looks good to me, thanks :) I'll approve it, as it's a very small doc update. For larger contributions, though, the workflow would be to submit a new PR for incorporating new feedback, roger? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's something very small, I think it's ok to go without new versions for the incorporated feedback. Can't confirm whether CLA was really signed or not.
@@ -12,7 +12,7 @@ a queue. Packets will be processed by one thread at a time, but there | |||
can be multiple packets being processed at a time by the engine (see | |||
:ref:`suricata-yaml-max-pending-packets`). A thread can have one or | |||
more thread-modules. If they have more modules, they can only be | |||
active one a a time. The way threads, modules and queues are arranged | |||
active one at a time. The way threads, modules and queues are arranged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another one :
git grep " a a "
doc/userguide/performance/hyperscan.rst:**Note:** Hyperscan can take a a long time to build/compile.
doc/userguide/performance/runmodes.rst:active one a a time. The way threads, modules and queues are arranged
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Describe changes: