Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add linktype name #12142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

output: Add linktype name #12142

wants to merge 3 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11994

Issue: 6954

This commit adds the linktype name to the output stream. The name is determined from a Rust linktype-to-name function.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954

Describe changes:

  • Include the linktype name alongside linktype
  • Update the schema with linktype_name
  • Custom linktype to name function in Rust.

Updates:

  • Rebase

Provide values to any of the below to override the defaults.

SV_BRANCH=OISF/suricata-verify#2023

Issue: 6954

Add Rust based logic that maintains a hash map of link type values and
their associated output names.
Use the hasmap to gather linktype display names.

Issue: 6954
Issue: 6954

This commit adds the linktype name to the output stream. The name is
determined from the pcap utility function pcap_datalink_val_to_name
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.81%. Comparing base (13841c0) to head (757f249).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12142      +/-   ##
==========================================
+ Coverage   49.77%   49.81%   +0.04%     
==========================================
  Files         909      911       +2     
  Lines      257884   257936      +52     
==========================================
+ Hits       128367   128497     +130     
+ Misses     129517   129439      -78     
Flag Coverage Δ
fuzzcorpus 60.97% <77.27%> (+0.04%) ⬆️
livemode 19.45% <72.72%> (+0.02%) ⬆️
pcap 44.43% <71.21%> (+0.02%) ⬆️
suricata-verify 62.70% <86.36%> (+0.01%) ⬆️
unittests 9.00% <62.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants