Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/642/70x/20241123/v1 #12143

Closed
wants to merge 1 commit into from
Closed

next/642/70x/20241123/v1 #12143

wants to merge 1 commit into from
+72 −21

Conversation

victorjulien
Copy link
Member

@catenacyber
detect/transforms: write directly in inspect buffer
f80ebd5 
instead of writing to a temporary buffer and then copying,
to save the cost of copying.

Ticket: 7229

Not a cherry-pick as we do not put the transforms in rust,
but just do this optimization in C
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23499

catenacyber
catenacyber approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the only approved PR :-p

@victorjulien
Copy link
Member Author

Replaced by #12146

@victorjulien victorjulien deleted the next/642/70x/20241123/v1 branch November 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @suricata-qa @catenacyber