Detect smtp keywords 7515 v1.2 #12473
Closed
+268
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7515 It is a sticky buffer mapping to the smtp.helo log field
Ticket: 7517 It is a sticky buffer mapping to the smtp.mail_from log field
Ticket: 7516 It is a sticky buffer mapping to the smtp.rcpt_to[] log field It is a multi-buffer
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
victorjulien
approved these changes
Jan 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12473 +/- ##
==========================================
- Coverage 80.52% 80.41% -0.12%
==========================================
Files 923 924 +1
Lines 259176 259267 +91
==========================================
- Hits 208708 208486 -222
- Misses 50468 50781 +313
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24350 |
Merged
|
Merged in #12480, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7515
https://redmine.openinfosecfoundation.org/issues/7516
https://redmine.openinfosecfoundation.org/issues/7517
Describe changes:
SV_BRANCH=OISF/suricata-verify#2254
#12468 with doc addition as per review