Skip to content

Commit

Permalink
Update activerecord requirement from ~> 7.2 to >= 7.2, < 9.0 (#68)
Browse files Browse the repository at this point in the history
* Update activerecord requirement from ~> 7.2 to >= 7.2, < 9.0

Updates the requirements on [activerecord](https://github.com/rails/rails) to permit the latest version.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v8.0.1/activerecord/CHANGELOG.md)
- [Commits](rails/rails@v7.2.2...v8.0.1)

---
updated-dependencies:
- dependency-name: activerecord
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update `raw_execute` signature

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lloyd Watkin <lloyd@olioex.com>
  • Loading branch information
dependabot[bot] and lloydwatkin authored Jan 6, 2025
1 parent b3626b0 commit 0bf4722
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 11 deletions.
18 changes: 10 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ PATH
remote: .
specs:
janus-ar (7.2.0)
activerecord (~> 7.2)
activerecord (>= 7.2, < 9.0)

GEM
remote: http://rubygems.org/
specs:
activemodel (7.2.2.1)
activesupport (= 7.2.2.1)
activerecord (7.2.2.1)
activemodel (= 7.2.2.1)
activesupport (= 7.2.2.1)
activemodel (8.0.1)
activesupport (= 8.0.1)
activerecord (8.0.1)
activemodel (= 8.0.1)
activesupport (= 8.0.1)
timeout (>= 0.4.0)
activesupport (7.2.2.1)
activesupport (8.0.1)
base64
benchmark (>= 0.3)
bigdecimal
Expand All @@ -25,6 +25,7 @@ GEM
minitest (>= 5.1)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
ast (2.4.2)
base64 (0.2.0)
benchmark (0.4.0)
Expand Down Expand Up @@ -93,13 +94,14 @@ GEM
rubocop (>= 1.48.1)
ruby-progressbar (1.13.0)
securerandom (0.4.1)
timeout (0.4.1)
timeout (0.4.3)
trilogy (2.9.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
unicode-display_width (3.1.3)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
uri (1.0.2)

PLATFORMS
arm64-darwin-23
Expand Down
2 changes: 1 addition & 1 deletion janus-ar.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Gem::Specification.new do |gem|

gem.required_ruby_version = '>= 3.2.0'

gem.add_dependency 'activerecord', '~> 7.2'
gem.add_dependency 'activerecord', '>= 7.2', '< 9.0'
gem.add_development_dependency 'activesupport', '>= 7.2.0'
gem.add_development_dependency 'mysql2'
gem.add_development_dependency 'trilogy'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ def with_connection(_args = {})
self
end

def raw_execute(sql, name, async: false, allow_retry: false, materialize_transactions: true)
def raw_execute(sql, name = nil, binds = [], prepare: false, async: false, allow_retry: false,
materialize_transactions: true, batch: false)
case where_to_send?(sql)
when :all
send_to_replica(sql, connection: :all, method: :raw_execute)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ def initialize(*args)
update_config
end

def raw_execute(sql, name, async: false, allow_retry: false, materialize_transactions: true)
def raw_execute(sql, name = nil, binds = [], prepare: false, async: false, allow_retry: false,
materialize_transactions: true, batch: false)
case where_to_send?(sql)
when :all
send_to_replica(sql, connection: :all, method: :execute)
Expand Down

0 comments on commit 0bf4722

Please sign in to comment.