Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change html font size to 100% so browser font size settings are respe… #3475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

admilne
Copy link
Contributor

@admilne admilne commented Jan 15, 2025

What is the context of this PR?

Fixes: ONSDESYS-229

When changing the font size settings in Chrome this had no impact on the font sizes displayed on the web page. A change has been made so the browser settings are respected.

Initially I set the font size on the html to be 100% but this then ignored ability to set the value of the $base font size. I've now updated this so the $base font size is still taken in to account.

How to review this PR

  1. Open a design system page in Chrome
  2. Open Chrome settings
  3. Go to the Appearance tab
  4. Alter the Font size settings
  5. Check this has updated the font sizes on the design system page
  6. Update the value of $base inside src/scss/vars/_typography.scss and make sure this value is respected

The visual regression tests should not fail.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@admilne admilne added the Accessibility Issues discovered through accessibility testing label Jan 15, 2025
@admilne admilne requested a review from a team January 15, 2025 18:21
@admilne admilne self-assigned this Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit c3aa88e
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6789403fba310a00088db1d4
😎 Deploy Preview https://deploy-preview-3475--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@admilne admilne changed the title Change html font size to 100% so browser font size settings are respe… DRAFT: Change html font size to 100% so browser font size settings are respe… Jan 16, 2025
@admilne admilne changed the title DRAFT: Change html font size to 100% so browser font size settings are respe… Change html font size to 100% so browser font size settings are respe… Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant