Some .NET 9 maintenance and JSON encoder improvements #2922
+426
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop/main374 #2922 +/- ##
===================================================
- Coverage 54.89% 46.39% -8.51%
===================================================
Files 349 349
Lines 66377 66396 +19
Branches 13624 13624
===================================================
- Hits 36437 30802 -5635
- Misses 25957 31878 +5921
+ Partials 3983 3716 -267 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj: Language not supported
- targets.props: Language not supported
- Libraries/Opc.Ua.Security.Certificates/X509Certificate/X509CertificateLoader.cs: Evaluated as low risk
- Tests/Opc.Ua.Core.Tests/Types/Encoders/JsonEncoderEscapeStringBenchmarks.cs: Evaluated as low risk
- Tests/Opc.Ua.Gds.Tests/Common.cs: Evaluated as low risk
- Tests/Opc.Ua.Client.Tests/SubscriptionTest.cs: Evaluated as low risk
- Tests/Opc.Ua.Core.Tests/Security/Certificates/ApplicationTestDataGenerator.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
Tests/Opc.Ua.Core.Tests/Types/Encoders/EncoderTests.cs:497
- The assertion Assert.IsTrue(nullspan == null) is incorrect because ReadOnlySpan cannot be null.
Assert.IsTrue(nullspan == null);
reduce string binarydecoder memory allocations
There was a problem hiding this comment.
Copilot reviewed 22 out of 35 changed files in this pull request and generated no comments.
Files not reviewed (13)
- Fuzzing/Encoders/Fuzz.Tests/Opc.Ua.Encoders.Fuzz.Tests.csproj: Language not supported
- Libraries/Opc.Ua.Client/Opc.Ua.Client.csproj: Language not supported
- Libraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj: Language not supported
- Stack/Opc.Ua.Core/Opc.Ua.Core.csproj: Language not supported
- Tests/Opc.Ua.Client.ComplexTypes.Tests/Opc.Ua.Client.ComplexTypes.Tests.csproj: Language not supported
- Tests/Opc.Ua.Client.Tests/Opc.Ua.Client.Tests.csproj: Language not supported
- Tests/Opc.Ua.Configuration.Tests/Opc.Ua.Configuration.Tests.csproj: Language not supported
- Tests/Opc.Ua.Core.Tests/Opc.Ua.Core.Tests.csproj: Language not supported
- Libraries/Opc.Ua.Client/Session/Session.cs: Evaluated as low risk
- Libraries/Opc.Ua.Client/Subscription/Subscription.cs: Evaluated as low risk
- Stack/Opc.Ua.Core/Types/Encoders/IEncoder.cs: Evaluated as low risk
- Libraries/Opc.Ua.Security.Certificates/X509Certificate/X509CertificateLoader.cs: Evaluated as low risk
- Stack/Opc.Ua.Core/Stack/Types/NotificationMessage.cs: Evaluated as low risk
This was
linked to
issues
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request includes various updates and improvements across multiple files. The changes focus on updating package references, enhancing debugging capabilities, and improving code efficiency and readability.
Fixes #2940
Fixes #2931
Package Reference Updates:
NUnitto version4.3.2andNUnit.Consoleto version3.19.0inFuzzing/Encoders/Fuzz.Tests/Opc.Ua.Encoders.Fuzz.Tests.csproj.System.Diagnostics.DiagnosticSourceto version6.0.2inStack/Opc.Ua.Core/Opc.Ua.Core.csproj.System.Formats.Asn1andMicrosoft.Bcl.CryptographyinLibraries/Opc.Ua.Security.Certificates/Opc.Ua.Security.Certificates.csproj. [1] [2]Debugging Enhancements:
#if DEBUGdirective to validate publish time and reject old values inSession.cs.Code Efficiency and Readability:
SaveMessageInCachemethod by removing redundant parameters and using object initializers inSubscription.cs. [1] [2]ServiceResultException.Createfor consistency in error messages inNodeId.cs. [1] [2] [3]New Features:
MoreNotificationsproperty toNotificationMessageandNotificationDataclasses to indicate if more notifications are expected. [1] [2]Miscellaneous:
Opc.Ua.Client.csproj.ReadStringmethod for performance improvement inBinaryDecoder.cs.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...