1013 fix arangodb startup script #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request modifies the changelog to document a fix in the ArangoDB startup script that improves error handling around service status checks. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JoshuaSBrown - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
CHANGELOG.md
Outdated
| @@ -12,7 +12,8 @@ | |||
| 3. [988] - Removed non-working subscribe function. | |||
| 4. [958] - Addresses issues raised by static code analyzer. | |||
| 5. [962] - Adds script that will check that docker image is in registry | |||
| 6. [1015] - Uses abs path to ci pipeline script for gcs build jobs | |||
| 6. [1015] - Use CI_BUILDS_DIR when checking gcs base image with harbor check | |||
There was a problem hiding this comment.
nitpick (documentation): Consider capitalizing the first letter to match the style of other entries
| @@ -12,7 +12,8 @@ | |||
| 3. [988] - Removed non-working subscribe function. | |||
| 4. [958] - Addresses issues raised by static code analyzer. | |||
| 5. [962] - Adds script that will check that docker image is in registry | |||
| 6. [1015] - Uses abs path to ci pipeline script for gcs build jobs | |||
| 6. [1015] - Use CI_BUILDS_DIR when checking gcs base image with harbor check | |||
| 7. [1013] - add set +e and set -e around is active check for arango service | |||
There was a problem hiding this comment.
nitpick (documentation): Entry needs capitalization and a period to match other entries' format
Consider: 'Added set +e and set -e around is active check for arango service.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: