Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker push tag #997

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Aug 29, 2024

Description

In installing a DataFed repo at Drexel, it was discovered that there were problems with the image containers. It turns out that the release CI pipelines were missing the :latest tag when pushing to the registry. This was causing the end-to-end tests to give false positives in the pipelines. It is fixed in the devel branch because the CI pipeline files were refactored. Merging this should cause the CI pipelines to reproduce the errors that Drexel and LeHigh were observing.

Summary by Sourcery

Fix the CI pipeline to include the ':latest' tag when pushing Docker images to the registry, addressing issues with image versioning and ensuring accurate end-to-end test results.

CI:

  • Add the ':latest' tag to Docker image pushes in the CI pipeline to ensure the latest version is correctly tagged and pushed to the registry.

Copy link

sourcery-ai bot commented Aug 29, 2024

Reviewer's Guide by Sourcery

This pull request fixes an issue with Docker image tagging in the CI/CD pipeline. The main change is adding the ':latest' tag when pushing Docker images to the registry, which was previously missing. This fix is crucial for ensuring proper image versioning and resolving false positives in end-to-end tests.

File-Level Changes

Change Details Files
Add ':latest' tag when pushing Docker images
  • Modified docker push commands to include ':latest' tag
  • Updated push commands for multiple services: ws, core, repo, gcs-base, gcs, and foxx
.gitlab-ci.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@JoshuaSBrown JoshuaSBrown added Type: Bug Something isn't working Component: Build Related to the build system labels Aug 29, 2024
@JoshuaSBrown JoshuaSBrown self-assigned this Aug 29, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoshuaSBrown - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JoshuaSBrown
Copy link
Collaborator Author

This was created off of a stale branch closing and opening a spearte branch with up to date commits.

@JoshuaSBrown JoshuaSBrown deleted the JoshuaSBrown-fix-release-ci-image-push-missing-tags branch August 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Related to the build system Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant