Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a LUSOL functionality test #164

Closed
wants to merge 18 commits into from
Closed

add a LUSOL functionality test #164

wants to merge 18 commits into from

Commits on Jun 21, 2024

  1. initial work on adding integration tests for lusol 

    - implemented matvec over COO matrices
- added back symmetric matrix expansion for COO matrices (temporary)
- reworked integration test code from KLU into integration test code for LUSOL (in progress, does not fully work)
- made minor tweaks to LinSolverDirectLUSOL
- set data ownership at exit of matrix-from-file conversion to avoid data leaks
- added a function to matrix::Sparse to set data ownership
    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f367ee8 View commit details
    Browse the repository at this point in the history

  2. finish the implementation of a LUSOL functionality test

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c87c32a View commit details
    Browse the repository at this point in the history

  3. undo modifications to formatting not part of code added

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    62d8476 View commit details
    Browse the repository at this point in the history

  4. actually undo formatting changes in Coo.cpp

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    96507e1 View commit details
    Browse the repository at this point in the history

  5. re-add changes to Coo.cpp

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    141c7a1 View commit details
    Browse the repository at this point in the history

  6. address review comments 

    - fix memory leak in `Csr` hijacking constructor
- add hijacking constructor to `Coo`
- remove needless use of `Sparse::setDataOwnership`/`Sparse::setValueOwnership`
- move `Coo::expand` to a separate function in `Utilities.cpp`
- add `Csr` expansion to `ReSolve::matrix::expand`
    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    424baf1 View commit details
    Browse the repository at this point in the history

  7. remove .clang-format

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    16dfd4d View commit details
    Browse the repository at this point in the history

  8. extract Coo matvec from MatrixHandlerCpu::matvec for now

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    04b0734 View commit details
    Browse the repository at this point in the history

  9. rework compute_error and add documentation comments to `matrix::exp… 

    …and`
    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    28f1b76 View commit details
    Browse the repository at this point in the history

  10. compute nnz_expanded in matrix expansion functions instead of relying… 

    … on the stated value
    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    01dd894 View commit details
    Browse the repository at this point in the history

  11. add tests for matrix expansion

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7a36e7c View commit details
    Browse the repository at this point in the history

  12. inline compute_error and use a forward-declaration for matvec

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a1ad741 View commit details
    Browse the repository at this point in the history

  13. csc matrix expansion + fix bug in matrix expansion tests

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e3907ed View commit details
    Browse the repository at this point in the history

  14. adjust documentation comment style + undo some changes made to resolv… 

    …e/matrix/io.cpp
    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b908396 View commit details
    Browse the repository at this point in the history

  15. address review comments

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5e69253 View commit details
    Browse the repository at this point in the history

  16. address the one last unique_ptr -> raw pointer suggestion

    @superwhiskers
    superwhiskers committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ff22890 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Update spack_cpu_build.yaml to build ~klu+lusol (#172)

    @cameronrutherford
    cameronrutherford authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    88840d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. adjust the wording of brief explanations for the expand functions

    @superwhiskers
    superwhiskers committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1f1e6f7 View commit details
    Browse the repository at this point in the history