alternate coo2csr implementation #175
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omments discussing possible implementation changes
pelesh
requested changes
Jul 15, 2024
resolve/matrix/Utilities.cpp
Outdated
Comment on lines
113
to
115
| if (new_columns[insertion_pos] == columns[i]) { | ||
| new_values[insertion_pos] = values[i]; | ||
| } else { |
There was a problem hiding this comment.
Why is it assignment here? Shouldn't it be adding in place?
Suggested change
| if (new_columns[insertion_pos] == columns[i]) { | |
| new_values[insertion_pos] = values[i]; | |
| } else { | |
| if (new_columns[insertion_pos] == columns[i]) { | |
| new_values[insertion_pos] += values[i]; | |
| } else { |
resolve/matrix/Utilities.cpp
Outdated
Comment on lines
106
to
111
| index_type insertion_pos = | ||
| static_cast<index_type>( | ||
| std::lower_bound(&new_columns[new_rows[rows[i]]], | ||
| &new_columns[new_rows[rows[i]] + used[rows[i]]], | ||
| columns[i]) | ||
| - new_columns); |
There was a problem hiding this comment.
Consider rewriting this as:
// Find first instance of columns[i] in the range from ...
auto lb = std::lower_bound(&new_columns[new_rows[rows[i]]],
&new_columns[new_rows[rows[i]] + used[rows[i]]],
columns[i]);
// Substract number of ... from the lower bound lb
lb -= new_columns;
index_type insertion_pos = static_cast<index_type>(lb);Also, it would be helpful to add comments before lines that are not quite obvious to explain what is done there. Perhaps using more intuitive variable names and adding comments before variable definition could help make code easier to read.
|
all of the comments above should be addressed now |
This was referenced Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a new coo2csr implementation, similar to the work done in #174, but written entirely from scratch, presumably with better performance (space/runtime---i've yet to benchmark it).