Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CMake #59

Closed
wants to merge 3 commits into from
Closed

Conversation

cameronrutherford
Copy link
Collaborator

@cameronrutherford cameronrutherford commented Nov 2, 2023

I will close remainder of #15 for AMD in Incline PR #53

@cameronrutherford
Copy link
Collaborator Author

Ready to merge as change is atomic and tests are passing

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running make test_install the consumer app build fails with following error:

-- HIP include directories: /opt/rocm-5.6.0/include
-- Configuring done
CMake Error at /ccs/home/peles/local/resolve-frontier/share/resolve/cmake/ReSolveTargets.cmake:64 (set_target_properties):
  The link interface of target "ReSolve::resolve_hip" contains:

    roc::rocblas

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /ccs/home/peles/local/resolve-frontier/share/resolve/cmake/ReSolveConfig.cmake:5 (include)
  CMakeLists.txt:10 (find_package)

I think this needs just a little tweak to get it to work. I am not sure what is going on, but sometimes HIP find function does not like roc:: namespace.

Otherwise changes look good!

@cameronrutherford
Copy link
Collaborator Author

Closing in favor of #53 as I cherry-picked commits into there and fixed bugs like the one you reported here @pelesh

@pelesh pelesh deleted the cmake-refactor-dev branch February 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants